Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_paginated_data when retrieving list of domains #307

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Use get_paginated_data when retrieving list of domains #307

merged 4 commits into from
Aug 11, 2023

Conversation

elcfd
Copy link
Contributor

@elcfd elcfd commented May 3, 2023

SUMMARY

Fixes #306 by using get_paginated_data

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

digital_ocean_domain module

ADDITIONAL INFORMATION

@elcfd
Copy link
Contributor Author

elcfd commented May 18, 2023

Hi @mamercad apologies for bothering you like this but is there an ETA on when this can be looked at? Currently having to run this module with a patch in my infrastructure. Thanks @elcfd

@mamercad
Copy link
Collaborator

mamercad commented Aug 9, 2023

Hi @mamercad apologies for bothering you like this but is there an ETA on when this can be looked at? Currently having to run this module with a patch in my infrastructure. Thanks @elcfd

Apologies, I've been swamped at $work, looking now.

Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, please kindly add a changelog fragment.

@elcfd
Copy link
Contributor Author

elcfd commented Aug 10, 2023

Hi @mamercad no problem - have added the changelog fragement as requested.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #307 (6d16808) into main (0946170) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   31.09%   31.10%           
=======================================
  Files          45       45           
  Lines        3589     3588    -1     
  Branches      732      732           
=======================================
  Hits         1116     1116           
+ Misses       2453     2452    -1     
  Partials       20       20           
Flag Coverage Δ
sanity 26.42% <0.00%> (+<0.01%) ⬆️
units 64.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/digital_ocean_domain.py 20.89% <0.00%> (+0.15%) ⬆️

@mamercad
Copy link
Collaborator

I think we'll need #310 before this passes tests, I'm working on it.

@mamercad
Copy link
Collaborator

I think we'll need #310 before this passes tests, I'm working on it.

@elcfd kindly rebase this against main and let's see how the tests look.

@elcfd
Copy link
Contributor Author

elcfd commented Aug 11, 2023

@mamercad have rebased against main as requested

@mamercad mamercad merged commit a40b214 into ansible-collections:main Aug 11, 2023
@mamercad
Copy link
Collaborator

Thanks for this ❤️

@elcfd
Copy link
Contributor Author

elcfd commented Aug 11, 2023

Thanks for this heart

@mamercad not a problem - glad to have sorted the bug - thanks for the help merging

@mamercad mamercad mentioned this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digital_ocean_domain: Fails if you have more than 20 domains
2 participants