-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use get_paginated_data when retrieving list of domains #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, please kindly add a changelog fragment.
Hi @mamercad no problem - have added the changelog fragement as requested. |
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 31.09% 31.10%
=======================================
Files 45 45
Lines 3589 3588 -1
Branches 732 732
=======================================
Hits 1116 1116
+ Misses 2453 2452 -1
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think we'll need #310 before this passes tests, I'm working on it. |
@mamercad have rebased against |
Thanks for this ❤️ |
@mamercad not a problem - glad to have sorted the bug - thanks for the help merging |
SUMMARY
Fixes #306 by using get_paginated_data
ISSUE TYPE
COMPONENT NAME
digital_ocean_domain module
ADDITIONAL INFORMATION