Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point PR integration tests at PR branch #292

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

mamercad
Copy link
Collaborator

@mamercad mamercad commented Oct 4, 2022

SUMMARY

Point pull request integration tests as the pull request branch (not the most recent commit); fixes #291.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • Integration tests

@mamercad mamercad requested a review from mpontillo October 4, 2022 12:13
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #292 (12aba90) into main (7db57a3) will decrease coverage by 32.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #292       +/-   ##
===========================================
- Coverage   63.20%   31.19%   -32.01%     
===========================================
  Files          45       45               
  Lines        3549     3549               
  Branches      720      720               
===========================================
- Hits         2243     1107     -1136     
- Misses       1006     2423     +1417     
+ Partials      300       19      -281     
Flag Coverage Δ
integration ?
sanity 26.48% <ø> (ø)
units 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/digital_ocean_droplet.py 10.33% <0.00%> (-58.36%) ⬇️
...lugins/modules/digital_ocean_domain_record_info.py 27.84% <0.00%> (-54.44%) ⬇️
plugins/modules/digital_ocean_database.py 16.21% <0.00%> (-52.03%) ⬇️
plugins/modules/digital_ocean_load_balancer.py 15.43% <0.00%> (-51.68%) ⬇️
plugins/modules/digital_ocean_snapshot.py 24.39% <0.00%> (-51.22%) ⬇️
plugins/modules/digital_ocean_floating_ip.py 20.11% <0.00%> (-46.93%) ⬇️
plugins/modules/digital_ocean_cdn_endpoints.py 24.69% <0.00%> (-46.92%) ⬇️
plugins/modules/digital_ocean_domain_info.py 41.02% <0.00%> (-46.16%) ⬇️
plugins/modules/digital_ocean_floating_ip_info.py 37.14% <0.00%> (-42.86%) ⬇️
plugins/modules/digital_ocean_block_storage.py 18.86% <0.00%> (-42.77%) ⬇️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mpontillo mpontillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mamercad mamercad merged commit a38b5c6 into main Oct 4, 2022
@mamercad mamercad deleted the mamercad/issue-291 branch October 4, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull request integration testing on commit (not branch)
2 participants