Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vpc key to returned VPC data on create #277

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Conversation

mamercad
Copy link
Collaborator

SUMMARY

Fixes #276.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.digitalocean.digital_ocean_vpc

@mamercad mamercad temporarily deployed to integration July 10, 2022 17:06 Inactive
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #277 (8340680) into main (7c12b8b) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   68.24%   68.24%           
=======================================
  Files          45       45           
  Lines        3549     3549           
  Branches      752      752           
=======================================
  Hits         2422     2422           
  Misses        801      801           
  Partials      326      326           
Flag Coverage Δ
integration 67.63% <66.66%> (ø)
sanity 26.48% <0.00%> (ø)
units 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/digital_ocean_vpc.py 64.44% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c12b8b...8340680. Read the comment docs.

@mamercad mamercad temporarily deployed to integration July 10, 2022 20:57 Inactive
@mamercad mamercad requested a review from mpontillo July 11, 2022 18:34
@mamercad mamercad merged commit a5eeeeb into main Jul 11, 2022
@mamercad mamercad deleted the mamercad/issue-276 branch July 11, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register objects have different schema depending on whether resource is created or already exists
2 participants