Don't throw an exception if API's JSON response lacks an expected key #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreywright
force-pushed
the
bugfix-Dont_call_get_on_None
branch
from
25142d6 to
4433eec
Compare
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 45 45
Lines 3549 3549
Branches 752 752
=======================================
Hits 2422 2422
Misses 801 801
Partials 326 326
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mamercad
reviewed
Jun 25, 2022
mamercad
requested changes
Jun 25, 2022
Instead of throwing an exception, be more defensive in the code: if
the API's JSON response lacks a key and we correspondingly set a
variable to `None`, then don't call `get()` on the variable, but test
the variable first.
AttributeError: 'NoneType' object has no attribute 'get'
Fixes ansible-collections#272.
coreywright
force-pushed
the
bugfix-Dont_call_get_on_None
branch
from
4433eec to
5cb930f
Compare
|
force pushed new commit to address comment(s) about changelog fragment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Instead of throwing an exception, be more defensive in the code: if
the API's JSON response lacks a key and we correspondingly set a
variable to
None, then don't callget()on the variable, but testthe variable first.
Fixes #272.
ISSUE TYPE
COMPONENT NAME
digital_ocean_droplet
ADDITIONAL INFORMATION