Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Droplet project_name parameter #256

Closed
wants to merge 7 commits into from
Closed

Conversation

mamercad
Copy link
Collaborator

SUMMARY

Fixes #255; the Droplet module's project_name parameter, and, add an integration test to make sure.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • digital_ocean_droplet

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #256 (03a0eb8) into main (0eec11e) will decrease coverage by 33.06%.
The diff coverage is 5.00%.

@@             Coverage Diff             @@
##             main     #256       +/-   ##
===========================================
- Coverage   64.11%   31.04%   -33.07%     
===========================================
  Files          45       45               
  Lines        3586     3595        +9     
  Branches      731      734        +3     
===========================================
- Hits         2299     1116     -1183     
- Misses        993     2460     +1467     
+ Partials      294       19      -275     
Flag Coverage Δ
integration ?
sanity 26.39% <5.00%> (-0.04%) ⬇️
units 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/digital_ocean_droplet.py 10.35% <5.00%> (-58.34%) ⬇️
plugins/modules/digital_ocean_project.py 19.62% <0.00%> (-64.49%) ⬇️
...lugins/modules/digital_ocean_domain_record_info.py 27.84% <0.00%> (-54.44%) ⬇️
plugins/modules/digital_ocean_database.py 16.21% <0.00%> (-52.03%) ⬇️
plugins/modules/digital_ocean_snapshot.py 24.39% <0.00%> (-51.22%) ⬇️
plugins/modules/digital_ocean_snapshot_info.py 40.00% <0.00%> (-47.50%) ⬇️
plugins/modules/digital_ocean_floating_ip.py 20.11% <0.00%> (-46.93%) ⬇️
plugins/modules/digital_ocean_cdn_endpoints.py 24.69% <0.00%> (-46.92%) ⬇️
plugins/modules/digital_ocean_domain_info.py 41.02% <0.00%> (-46.16%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mamercad mamercad temporarily deployed to integration October 6, 2022 11:46 Inactive
@mamercad mamercad temporarily deployed to integration October 6, 2022 12:40 Inactive
@mamercad mamercad temporarily deployed to integration October 6, 2022 18:08 Inactive
@mamercad mamercad temporarily deployed to integration October 6, 2022 23:40 Inactive
@mamercad
Copy link
Collaborator Author

I'm going to close this in favor of the next major version of the collection.

@mamercad mamercad closed this Jan 22, 2023
@raman-babich
Copy link
Contributor

@mamercad Why can't we merge it to 1.x.x version?

@mamercad
Copy link
Collaborator Author

mamercad commented Dec 4, 2023

@mamercad Why can't we merge it to 1.x.x version?

I've personally stopped development on this collection in favor of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Droplet project_name not working
2 participants