Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no_log=True for aws_access_key_id parameter #244

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

mamercad
Copy link
Collaborator

@mamercad mamercad commented May 1, 2022

SUMMARY

Fixes #243.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • digital_ocean_spaces
  • digital_ocean_spaces_info

@mamercad mamercad temporarily deployed to integration May 1, 2022 10:26 Inactive
@mamercad mamercad requested a review from mpontillo May 1, 2022 10:26
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #244 (df4ffa7) into main (ceb0c78) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   68.29%   68.40%   +0.11%     
==========================================
  Files          45       45              
  Lines        3539     3539              
  Branches      750      750              
==========================================
+ Hits         2417     2421       +4     
+ Misses        797      795       -2     
+ Partials      325      323       -2     
Flag Coverage Δ
integration 67.76% <ø> (+0.12%) ⬆️
sanity 26.47% <ø> (ø)
units 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/digital_ocean_spaces.py 74.32% <ø> (ø)
plugins/modules/digital_ocean_spaces_info.py 87.50% <ø> (ø)
plugins/modules/digital_ocean_droplet.py 69.60% <0.00%> (+0.60%) ⬆️
plugins/modules/digital_ocean_firewall.py 49.64% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb0c78...df4ffa7. Read the comment docs.

@mamercad mamercad merged commit 76544f4 into main May 3, 2022
@mamercad mamercad deleted the mamercad/issue-243 branch May 3, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set aws_access_key_id to no_log
2 participants