Add an approval step and gate on it (#339)

ansible-collections · Jan 1, 2024 · fe57aa2 · fe57aa2
1 parent fb2e040
commit fe57aa2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/pull-request-integration.yml b/.github/workflows/pull-request-integration.yml
@@ -19,13 +19,23 @@ env:
   PR_NUMBER: ${{ github.event.pull_request.number }}
 
 jobs:
-  test-integration:
+  human-review-and-approval:
     runs-on: ubuntu-22.04
     # MUST keep this environment set if using pull_request_target
     environment: integration
-    timeout-minutes: 60
+    steps:
+      - name: Wait for approval
+        run: sleep infinity
+
+  test-integration:
+    needs: human-review-and-approval
+    runs-on: ubuntu-22.04
+    # NOTE using the 'needs' as a gate ... the 'integration' environment has
+    # required reviewers (which is a good idea since we're using pull_request_target)
+    timeout-minutes: 90
     strategy:
       fail-fast: false
+      # NOTE we're hitting 429s (too many requests)
       max-parallel: 1
       matrix:
         versions:

diff --git a/changelogs/fragments/339-refactor-integration-tests.yml b/changelogs/fragments/339-refactor-integration-tests.yml
@@ -0,0 +1,2 @@
+trivial:
+  - ci - refactor pull request integration test workflow (https://github.com/ansible-collections/community.digitalocean/pull/339).
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		trivial:
		- ci - refactor pull request integration test workflow (https://github.com/ansible-collections/community.digitalocean/pull/339).