added overridden state for cisco.nxos_telemetry #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
==========================================
+ Coverage 84.91% 85.18% +0.26%
==========================================
Files 221 233 +12
Lines 18606 19065 +459
==========================================
+ Hits 15799 16240 +441
- Misses 2807 2825 +18 |
|
The changes looks good to me! |
AAYUSH2091
changed the title
NilashishC
approved these changes
Jan 9, 2025
KB-perByte
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support for 'overridden' state to cisco.nxos.telemetry module and included corresponding test cases. The overridden state functionality behaves similarly to the replaced state, allowing users to completely override the existing telemetry configuration with their specified configuration.
COMPONENT NAME
cisco.nxos.telemetry