Fix nxos_facts integration test (#917)

* Add/Test Integration

* test - 2

* fix facts tests and changes in integation

* fix

* remove file_copy ignore

* file copy fix

* fixes fstring error

* added changelog

* file copy

* remove vpc


merging this with upstream ci fail as these are related to cml

changelogs/fragments/tests_fix.yaml

@@ -0,0 +1,5 @@
+---
+bugfixes:
+  - Fixes mixed usage of f-string and format string in action plugin for consistency.
+trivial:
+  - Added tests fixes for nxos_facts.

plugins/action/nxos.py

@@ -60,8 +60,7 @@ def run(self, tmp=None, task_vars=None):
                     "msg": (
                         f"Connection type must be fully qualified name for "
                         f"network_cli connection type, got {self._play_context.connection}"
-                    )
-                    % self._play_context.connection,
+                    ),
                 }
 
             conn = Connection(self._connection.socket_path)

tests/integration/targets/nxos_facts/vars/main.yml

@@ -28,4 +28,6 @@ available_network_resources:
   - static_routes
   - telemetry
   - vlans
+  - vrf_address_family
   - vrf_global
+  - vrf_interfaces

tests/integration/targets/nxos_file_copy/tests/cli/input_validation.yaml

@@ -21,7 +21,7 @@
 
 - ansible.builtin.assert:
     that:
-      - result is search("argument 'file_pull_timeout' is of type .* and we were unable to convert to int")
+      - result.msg is ansible.builtin.search("argument 'file_pull_timeout' is of type .* and we were unable to convert to int", multiline=true)
 
 - name: Input validation - param should be type <bool>
   register: result