getting rid of Ignores for sanity tests #62
Conversation
rohitthakur2590
force-pushed
the
sanity_ignore_list_fix
branch
from
91f9579 to
87f956f
Compare
| @@ -1089,7 +1151,7 @@ def main(): | |||
| hostnameprefix=dict(type="str"), | |||
| level=dict( | |||
| type="str", | |||
| default="informational", | |||
| default="debugging", | |||
There was a problem hiding this comment.
I guess this was changed based on what the default is set in the doc for this key? Shouldn't it be the other way round i.e., updating the doc based on what's there in argspec? Changing the default value of a key in argspec can have other side effects.
There was a problem hiding this comment.
yes, this should be based on the default value in doc key as which is aligned with cisco IOS-XR default value for severity argument.
There was a problem hiding this comment.
So what I meant was, since the default value of a key is fetched from argument spec and not the doc while being used for computing, it is quite possible that changing it to something else may cause unintended effects and also break existing plays that rely on the default behaviour of level to be debugging.
There was a problem hiding this comment.
Having said that, I do not know what the default logging level is in IOS-XR and whether it varies between different versions.
There was a problem hiding this comment.
IMO we should go for what's there in ansible iosxr_logging supported by iosxr platform documentation. What we have right now in our argument spec is a programming mistake or a potential bug.
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
sanity_ignore_list_fix
branch
from
b764845 to
944d7cf
Compare
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
sanity_ignore_list_fix
branch
2 times, most recently
from
6d1a4d7 to
3641606
Compare
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
rohitthakur2590
force-pushed
the
sanity_ignore_list_fix
branch
from
3641606 to
f696dfe
Compare
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
Signed-off-by: Rohit Thakur rohitthakur2590@outlook.com
SUMMARY
Resolve: #57
ISSUE TYPE
COMPONENT NAME
iosxr_.*
ADDITIONAL INFORMATION