Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple local-preference #518

Conversation

AAYUSH2091
Copy link
Contributor

@AAYUSH2091 AAYUSH2091 commented Oct 22, 2024

SUMMARY

Adds support for single local-preference values in route maps with special characters (*,+,-).

Fixes the issue with local-preference values not being captured correctly in route-maps.

Fixes #516

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iosxr_route_maps

@Ruchip16
Copy link
Contributor

Ruchip16 commented Oct 23, 2024

@AAYUSH2091 can you please add changelog

@AAYUSH2091 AAYUSH2091 force-pushed the feature/add-local-preference-support branch from e1d82a1 to 29bd8ed Compare October 28, 2024 11:18
@AAYUSH2091 AAYUSH2091 force-pushed the feature/add-local-preference-support branch from d6c92ec to 22b8424 Compare October 30, 2024 10:54
@AAYUSH2091
Copy link
Contributor Author

@KB-perByte please review this once I have also added the integration tests as well to support multiple local-preference values.

@AAYUSH2091 AAYUSH2091 force-pushed the feature/add-local-preference-support branch from 5e9bae0 to ad56785 Compare November 7, 2024 13:29
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (8f9341d) to head (a14370d).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   76.91%   78.52%   +1.60%     
==========================================
  Files         166      182      +16     
  Lines       11298    11953     +655     
==========================================
+ Hits         8690     9386     +696     
+ Misses       2608     2567      -41     

see 120 files with indirect coverage changes

@AAYUSH2091 AAYUSH2091 requested a review from KB-perByte November 7, 2024 13:49
@AAYUSH2091 AAYUSH2091 changed the title add support for single local-preference add support for multiple local-preference Nov 18, 2024
@AAYUSH2091 AAYUSH2091 merged commit 5070f32 into ansible-collections:main Dec 30, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[route-maps] set local-preference <number> not being handled
4 participants