Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iosxr_vrf_global resource module #467

Merged
merged 37 commits into from
Jun 6, 2024
Merged

Add iosxr_vrf_global resource module #467

merged 37 commits into from
Jun 6, 2024

Conversation

Ruchip16
Copy link
Contributor

@Ruchip16 Ruchip16 commented Jan 24, 2024

SUMMARY

This PR adds support for iosxr_vrf_global resource module

DESCRIPTION

Here is the model design for the iosxr_vrf_global & iosxr_vrf_address_family resource module

Fixes #449 #462

ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

cisco.iosxr.iosxr_vrf_global

MILESTONES
  • Parsing entire argspec ( which covers gathered and parsed state )
  • Merged and Deleted state working
  • Replaced state working
  • Overridden state working
  • Unit tests & Integration tests

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.58%. Comparing base (8f9341d) to head (3c473a5).
Report is 17 commits behind head on main.

Current head 3c473a5 differs from pull request most recent head e97d4dc

Please upload reports for the commit e97d4dc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   76.91%   77.58%   +0.67%     
==========================================
  Files         166      170       +4     
  Lines       11298    11431     +133     
==========================================
+ Hits         8690     8869     +179     
+ Misses       2608     2562      -46     

see 46 files with indirect coverage changes

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e11f4b6ed1774293927e957c4269cd99

✔️ ansible-galaxy-importer SUCCESS in 3m 28s
✔️ build-ansible-collection SUCCESS in 10m 33s
✔️ ansible-tox-linters SUCCESS in 12m 49s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d2258fe7a2844c61b4128c2339d8d318

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 9m 41s
✔️ ansible-tox-linters SUCCESS in 11m 57s

plugins/modules/iosxr_vrf.py Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf.py Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf.py Outdated Show resolved Hide resolved
plugins/module_utils/network/iosxr/facts/vrf/vrf.py Outdated Show resolved Hide resolved
plugins/module_utils/network/iosxr/facts/vrf/vrf.py Outdated Show resolved Hide resolved
plugins/module_utils/network/iosxr/rm_templates/vrf.py Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf.py Outdated Show resolved Hide resolved
plugins/modules/iosxr_vrf.py Outdated Show resolved Hide resolved
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ab018d15234f437095e483520dcb08c7

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 9m 54s
✔️ ansible-tox-linters SUCCESS in 12m 04s

@Ruchip16 Ruchip16 merged commit 9982730 into main Jun 6, 2024
54 checks passed
@Ruchip16 Ruchip16 deleted the feature-vrf branch June 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request. vrf_global vrf_global resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General VRF Support
4 participants