Merge branch 'main' into add_cdp_neighbors

ansible-collections · Dec 13, 2023 · d436f01 · d436f01
2 parents aaf2d5b + a1a6829
commit d436f01
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 8 deletions.
diff --git a/changelogs/fragments/fix_iosxr_config.yaml b/changelogs/fragments/fix_iosxr_config.yaml
@@ -0,0 +1,3 @@
+---
+trivial:
+  - Fix iosxr_config integration tests
diff --git a/tests/integration/targets/iosxr_config/tests/cli/backup.yaml b/tests/integration/targets/iosxr_config/tests/cli/backup.yaml
@@ -19,7 +19,7 @@
 - ansible.builtin.assert:
     that:
       - result.changed == true
-      - result.updates is not defined
+      - result.updates is defined
 
 - name: Delete configurable backup file path
   ansible.builtin.file:

diff --git a/tests/integration/targets/iosxr_config/tests/cli/comment-too-long.yaml b/tests/integration/targets/iosxr_config/tests/cli/comment-too-long.yaml
@@ -20,7 +20,6 @@
 - ansible.builtin.assert:
     that:
       - result.changed == false
-      - result.updates is not defined
       - "'comment argument cannot be more than 60 characters' in result.msg"
 
 - ansible.builtin.debug: msg="END cli/comment-too-long.yaml on connection={{ ansible_connection }}"
diff --git a/tests/integration/targets/iosxr_config/tests/cli/comment.yaml b/tests/integration/targets/iosxr_config/tests/cli/comment.yaml
@@ -20,7 +20,7 @@
 - ansible.builtin.assert:
     that:
       - result.changed == true
-      - result.updates is not defined
+      - result.updates is defined
 
 - name: Check device with configuration
   register: result
@@ -31,7 +31,6 @@
 - ansible.builtin.assert:
     that:
       - result.changed == false
-      - result.updates is not defined
 
 - name: Assert accurately report configuration failure during pseudo-atomic operation
   register: result

diff --git a/tests/integration/targets/iosxr_config/tests/cli/src_basic.yaml b/tests/integration/targets/iosxr_config/tests/cli/src_basic.yaml
@@ -18,7 +18,7 @@
 - ansible.builtin.assert:
     that:
       - result.changed == true
-      - result.updates is not defined
+      - result.updates is defined
 
 - name: Check device with configuration
   register: result
@@ -28,6 +28,5 @@
 - ansible.builtin.assert:
     that:
       - result.changed == false
-      - result.updates is not defined
 
 - ansible.builtin.debug: msg="END cli/src_basic.yaml on connection={{ ansible_connection }}"
diff --git a/tests/integration/targets/iosxr_config/tests/cli/src_match_none.yaml b/tests/integration/targets/iosxr_config/tests/cli/src_match_none.yaml
@@ -19,7 +19,7 @@
 - ansible.builtin.assert:
     that:
       - result.changed == true
-      - result.updates is not defined
+      - result.updates is defined
 
 - name: Check device with configuration
   register: result
@@ -29,6 +29,5 @@
 - ansible.builtin.assert:
     that:
       - result.changed == false
-      - result.updates is not defined
 
 - ansible.builtin.debug: msg="END cli/src_match_none.yaml on connection={{ ansible_connection }}"