Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ipv6 remark parsing in older device #1159

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

roverflow
Copy link
Member

@roverflow roverflow commented Feb 16, 2025

SUMMARY

Fixes ipv6 remark parsing/processing in older device

Trival:
Also fixes error in integration test for lldp_interfaces

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ios_acls.py
ADDITIONAL INFORMATION

The cisco.ios.ios_acls module errors out when adding a remark to an IPv6 ACL ACE. This happens because the module does not properly process IPv6 ACL remarks, leading to unsupported parameters (is_remark_for, order, the_remark). The issue occurs specifically when an IPv6 ACL with a remark exists on the device.

Example:

Initial config in device causing error:

 ipv6 access-list extended std_acl_name_test_1
     10 remark std_acl_name_test_1
     20 permit 220 any any

run play:

- name: Ios acls test
  hosts: all
  gather_facts: False
  tasks:
    - name: Add ACL
      cisco.ios.ios_acls:
        config:
          - afi: ipv6
            acls:
              - name: new_test
                acl_type: extended
                aces:
                  - remarks:
                      - "Test_ipv4_ipv6_acl"
                  - destination:
                      any: true
                    grant: permit
                    protocol: 220
                    sequence: 40
                    source:
                      any: true
        state: merged

error:

ASK [Add ACL] ************************************************************************************************** fatal: [3850-01]: 
FAILED! => {   
 "changed": false,  
 "msg": "Unsupported parameters for (basic.py) module: config.acls.aces.is_remark_for, config.acls.aces.order, config.acls.aces.the_remark. Supported parameters include: destination, dscp, enable_fragments, evaluate, grant, log, log_input, option, precedence, protocol, protocol_options, remarks, sequence, source, time_range, tos, ttl." 
}

Fix:
There was a line commented that was supposed to process the ipv6 remartks which is now uncommented

@github-actions github-actions bot added the safe to test For network-integration jobs label Feb 16, 2025
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (0635a8e) to head (4440610).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
+ Coverage   87.35%   87.40%   +0.04%     
==========================================
  Files         212      212              
  Lines       12522    12562      +40     
==========================================
+ Hits        10939    10980      +41     
+ Misses       1583     1582       -1     

see 8 files with indirect coverage changes

@roverflow roverflow requested a review from Ruchip16 February 17, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test For network-integration jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants