-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ipv6 remark parsing in older device #1159
Open
roverflow
wants to merge
7
commits into
ansible-collections:main
Choose a base branch
from
roverflow:bug/fix_ipv6_remark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
+ Coverage 87.35% 87.40% +0.04%
==========================================
Files 212 212
Lines 12522 12562 +40
==========================================
+ Hits 10939 10980 +41
+ Misses 1583 1582 -1 |
Ruchip16
reviewed
Feb 16, 2025
Ruchip16
approved these changes
Feb 17, 2025
rohitthakur2590
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes ipv6 remark parsing/processing in older device
Trival:
Also fixes error in integration test for lldp_interfaces
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
The cisco.ios.ios_acls module errors out when adding a remark to an IPv6 ACL ACE. This happens because the module does not properly process IPv6 ACL remarks, leading to unsupported parameters (is_remark_for, order, the_remark). The issue occurs specifically when an IPv6 ACL with a remark exists on the device.
Example:
Initial config in device causing error:
run play:
error:
Fix:
There was a line commented that was supposed to process the ipv6 remartks which is now uncommented