Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep release 6.1.0 #249

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Prep release 6.1.0 #249

wants to merge 5 commits into from

Conversation

KB-perByte
Copy link
Contributor

No description provided.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/05903101326043399e050c742ad01318

✔️ ansible-galaxy-importer SUCCESS in 3m 43s
✔️ build-ansible-collection SUCCESS in 7m 15s
❌ ansible-test-network-integration-asa-python39 RETRY_LIMIT in 7m 23s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable212 FAILURE in 4m 36s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable214 FAILURE in 5m 02s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable211 FAILURE in 4m 24s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable29 FAILURE in 5m 19s (non-voting)
❌ ansible-test-network-integration-asa-libssh-python39 RETRY_LIMIT in 3m 21s
❌ ansible-test-network-integration-asa-libssh-python38-stable214 FAILURE in 6m 48s
❌ ansible-test-network-integration-asa-libssh-python38-stable212 FAILURE in 7m 22s
❌ ansible-test-network-integration-asa-libssh-python38-stable211 FAILURE in 6m 41s
❌ ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 7m 25s (non-voting)
❌ ansible-tox-linters FAILURE in 4m 36s

NilashishC
NilashishC reviewed Jan 6, 2025
View reviewed changes
CHANGELOG.rst
@@ -31,7 +50,7 @@ v5.0.0
Release Summary
---------------

Starting from this release, the minimum `ansible-core` version this collection requires is `2.14.0`. The last known version compatible with ansible-core<2.14 is `v4.0.3`.
Starting from this release, the minimum `ansible-core` version this collection requires is `2.14.0`. The last known version compatible with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no no, someone manually updated it, and the tool put's it in to the correct place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the sentence is incomplete here. Need to add words after: "The last known version compatible with".

NilashishC
NilashishC reviewed Jan 6, 2025
View reviewed changes
galaxy.yml Outdated
@@ -13,4 +13,4 @@ issues: https://github.com/ansible-collections/cisco.asa/issues
tags: [cisco, asa, networking, security]
# NOTE(pabelanger): We create an empty version key to keep ansible-galaxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this note please? :)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/083d8a060ade4870a962fb0f93adeff9

✔️ ansible-galaxy-importer SUCCESS in 6m 00s
✔️ build-ansible-collection SUCCESS in 7m 16s
❌ ansible-test-network-integration-asa-python39 RETRY_LIMIT in 7m 29s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable212 RETRY_LIMIT in 7m 18s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable214 FAILURE in 5m 22s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable211 FAILURE in 5m 15s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable29 FAILURE in 5m 04s (non-voting)
❌ ansible-test-network-integration-asa-libssh-python39 RETRY_LIMIT in 3m 14s
❌ ansible-test-network-integration-asa-libssh-python38-stable214 FAILURE in 6m 33s
❌ ansible-test-network-integration-asa-libssh-python38-stable212 FAILURE in 6m 42s
❌ ansible-test-network-integration-asa-libssh-python38-stable211 FAILURE in 6m 41s
❌ ansible-test-network-integration-asa-libssh-python38-stable29 RETRY_LIMIT in 7m 19s (non-voting)
❌ ansible-tox-linters FAILURE in 4m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d116e146f6c842d8ac45f9e35432ba0d

✔️ ansible-galaxy-importer SUCCESS in 3m 16s
✔️ build-ansible-collection SUCCESS in 6m 47s
❌ ansible-test-network-integration-asa-python39 RETRY_LIMIT in 7m 16s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable212 FAILURE in 4m 24s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable214 FAILURE in 4m 39s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable211 FAILURE in 4m 26s (non-voting)
❌ ansible-test-network-integration-asa-python38-stable29 FAILURE in 5m 15s (non-voting)
❌ ansible-test-network-integration-asa-libssh-python39 RETRY_LIMIT in 3m 35s
❌ ansible-test-network-integration-asa-libssh-python38-stable214 FAILURE in 6m 27s
❌ ansible-test-network-integration-asa-libssh-python38-stable212 FAILURE in 6m 32s
❌ ansible-test-network-integration-asa-libssh-python38-stable211 FAILURE in 6m 32s
❌ ansible-test-network-integration-asa-libssh-python38-stable29 FAILURE in 7m 02s (non-voting)
❌ ansible-tox-linters FAILURE in 4m 32s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NilashishC NilashishC NilashishC left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KB-perByte @NilashishC