Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection details to azure_rm_privateendpoint_info #965

Merged
merged 11 commits into from
Sep 9, 2022
Merged

Add connection details to azure_rm_privateendpoint_info #965

merged 11 commits into from
Sep 9, 2022

Conversation

dhageman
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

This code modifies azure_rm_privateendpoint_info to return the connection details associated with a private endpoint. This is necessary for private endpoints that don't connect to a private link service as the newly added azure_rm_privateendpointconnection_info only supports those type of links. The primary motivation for this feature is to allow identification of private endpoints that are pointing to resources which no longer exist.

ADDITIONAL INFORMATION

This pull request introduces a change in the output of the command. It will return a complex type instead of an array of connection id strings.

Old result:

                "private_link_service_connections": [
                    "/subscriptions/xxx-xxx-xxx/resourceGroups/rg-infrastructure/providers/Microsoft.Network/privateEndpoints/pe-aks-z6fjatiyrb3kc-6addcd51/privateLinkServiceConnections/pe-aks-z6fjatiyrb3kc-6addcd51"
                ],

New result:

                "private_link_service_connections": [
                    {
                        "connection_state": {
                            "actions_required": "None",
                            "description": "Auto Approved",
                            "status": "Disconnected"
                        },
                        "group_ids": [
                            "management"
                        ],
                        "id": "/subscriptions/xxx-xxx-xxxx/resourceGroups/rg-infrastructure/providers/Microsoft.Network/privateEndpoints/pe-aks-z6fjatiyrb3kc--6addcd51/privateLinkServiceConnections/pe-aks-z6fjatiyrb3kc-6addcd51",
                        "name": "pe-aks-z6fjatiyrb3kc-6addcd51",
                        "type": "Microsoft.Network/privateEndpoints/privateLinkServiceConnections"
                    }
                ],

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Aug 30, 2022
dhageman and others added 2 commits August 30, 2022 09:38
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete lines 160 to 166

plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_privateendpoint_info.py Outdated Show resolved Hide resolved
dhageman and others added 6 commits August 30, 2022 10:47
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Aug 31, 2022
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Sep 9, 2022

@dhageman LGTM 🚢

@xuzhang3 xuzhang3 merged commit 2998043 into ansible-collections:dev Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants