-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new module azure_rm_account_info
to get facts for current logged in user
#922
Add new module azure_rm_account_info
to get facts for current logged in user
#922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mandar242 Thanks for this pull request.
Could you please add some integration tests for this module?
except CloudError as exc: | ||
self.fail("Failed to list all subscriptions - {0}".format(str(exc))) | ||
|
||
results['id'] = subscription_list_response[0].subscription_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a choice to return only the first subscription [0]
for the account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the documentation and based on my trial-errors for az account show
here: https://docs.microsoft.com/en-us/cli/azure/account?view=azure-cli-latest#az-account-show
I felt that it returns a single subscription, so adding [0]
th subscription.
I could be wrong here though. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider deleting lines in the module that are not useful for modifying comments. Thank you very much!
LGTM |
SUMMARY
Add new module
azure_rm_account_info
.Provides output equivalent to
az account show
.ISSUE TYPE
COMPONENT NAME
azure_rm_account_info
ADDITIONAL INFORMATION
Makes use of below to create a output containing details similar to and of similar format to
az account show