-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new monitor diagnostic setting modules #701
Add new monitor diagnostic setting modules #701
Conversation
Hi @Fred-sun, here is a module which I think will be very helpful for people. I saw #530 addressed the same issue, but the PR was quite stale and did not offer much flexibility. So I have raised this PR and hope it will be useful. Please review and advise--thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3ender A lot of normative questions about module documentation, Please refer to the link - https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#developing-modules-documen ting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3ender The return value suboption paramter is "contain", not suboptions. Thank you!
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Thanks for the review, @Fred-sun, and sorry for the silly documentation syntax mistakes. Thanks for providing the URL for detail on how to generate documentation; I will be looking more into that. Please take another look. Thank you! |
Hello, wondering if there is anything else I can do for this PR? Thank you! |
@l3ender We are reviewing and will push forward the merger as soon as possible. Thank you very much! |
Hello, is anything else desired for this PR? Thank you! |
@l3ender LGTM, shipping it. |
SUMMARY
This PR adds support for configuring diagnostic settings for any Azure resource. Log and/or metric information from the resource can be sent to a variety of destinations.
An example which sends log information from an app service to an event hub:
Fixes #529.
ISSUE TYPE
COMPONENT NAME
azure_rm_monitordiagnosticsetting
azure_rm_monitordiagnosticsetting_info
ADDITIONAL INFORMATION
I have added extensive test coverage, which can be run using a playbook like the following: