Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct idempotency for azure_rm_appserviceplan and premium SKU plans #693

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Nov 20, 2021

SUMMARY

This PR corrects idempotency for azure_rm_appserviceplan with premium SKU plans.

Fixes #692.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_appserviceplan

ADDITIONAL INFORMATION

I have corrected and added a test to verify. The tests can be ran as follows:

---
- name: "Playbook for testing."
  hosts: "localhost"
  connection: "local"
  gather_facts: false
  vars:
    resource_group: "automated-testing"
    resource_group_secondary: "automated-testing-secondary"
  collections:
    - azure.azcollection

  tasks:
    - name: "Include tests"
      include_tasks: "tests/integration/targets/azure_rm_appserviceplan/tasks/main.yml"

@l3ender
Copy link
Contributor Author

l3ender commented Nov 20, 2021

@Fred-sun Please review...thank you!

@Fred-sun Fred-sun added enhancement New feature or request medium_priority Medium priority new_feature New feature requirments work in In trying to solve, or in working with contributors labels Nov 22, 2021
@Fred-sun
Copy link
Collaborator

@l3ender Okay, we'll move forward with the merger as soon as possible. Thank you for your contribution!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Nov 22, 2021
@xuzhang3
Copy link
Collaborator

LGTM

@xuzhang3 xuzhang3 merged commit 5e1b4b9 into ansible-collections:dev Nov 23, 2021
@xuzhang3 xuzhang3 deleted the app-service-premium-plans branch November 23, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_rm_appserviceplan not idempotent for premium app service plans
3 participants