Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subnet lookup for app gateway #451

Merged
merged 8 commits into from
Apr 12, 2021

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Mar 11, 2021

SUMMARY

This PR updates the app gateway module so a subnet can be provided by name and virtual network name, as opposed to needing the full subnet resource ID.

This change is backward compatible and will complement existing playbooks which use subnet resource ID.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/azure_rm_appgateway.py

ADDITIONAL INFORMATION

Before:

- name: Create instance of Application Gateway
  azure_rm_appgateway:
    ...
    gateway_ip_configurations:
      - subnet:
          id: /subscriptions/xxxxxxxxx-xxxx-xxxx-xxxxxxxxxxxxxx/resourceGroups/myresourcegroup/providers/Microsoft.Network/virtualNetworks/myvnet/subnets/myvnet-appgateway-subnet
        name: app_gateway_ip_config

After:

- name: Create instance of Application Gateway
  azure_rm_appgateway:
    ...
    gateway_ip_configurations:
      - subnet:
          name: myvnet-appgateway-subnet
          virtual_network_name: myvnet
        name: app_gateway_ip_config

@Fred-sun
Copy link
Collaborator

@l3ender Thank you for your contribution. We will complete the review and push forward the merger as soon as possible! Thank you very much!

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Mar 18, 2021
@Fred-sun
Copy link
Collaborator

@l3ender lines 705,706,707,740,741 continuation line over indented for visual indent! Thank you very much!

@l3ender
Copy link
Contributor Author

l3ender commented Mar 26, 2021

@Fred-sun Updated, thank you!

@l3ender l3ender requested a review from Fred-sun March 26, 2021 18:35
@Fred-sun
Copy link
Collaborator

@l3ender Now that you have described the molecular parameters of the document, could you help define those parameters in args_spec? This keeps the document consistent with arg_spec. Thank you very much!

@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Mar 31, 2021
@haiyuazhang haiyuazhang merged commit f312129 into ansible-collections:dev Apr 12, 2021
@l3ender l3ender deleted the subnet-lookup branch May 12, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants