Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_storageaccount_info, azure_rm_storageaccount - Identity storageaccount #1639

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

p3ck
Copy link
Collaborator

@p3ck p3ck commented Jul 17, 2024

SUMMARY

Add Managed Identity support to storageaccount module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/azure_rm_storageaccount.py
plugins/modules/azure_rm_storageaccount_info.py
tests/integration/targets/azure_rm_storageaccount/tasks/main.yml

ADDITIONAL INFORMATION

This relies on #1635 to be able to update identities properly. I'll rebase this PR once that one is merged.

Some API endpoints use PATCH Rest API and will append UserAssignedIdentities
without removing the original ones.  To remove the original entries you must
specify None for the value of the key you want to remove.
@p3ck p3ck requested review from Fred-sun and nirarg July 17, 2024 15:46
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Jul 23, 2024
@xuzhang3 xuzhang3 merged commit e5ea1ed into ansible-collections:dev Jul 23, 2024
@xuzhang3 xuzhang3 changed the title Identity storageaccount azure_rm_storageaccount_info, azure_rm_storageaccount - Identity storageaccount Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants