Add azure-mgmt-frontdoor to enable WAF functionality #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jartoo No module depends on this package, so why add this package? |
Fred-sun
added
question
|
I was adding this to cover the upcoming azure_rm_frontdoorpolicy.py module, which will cover the WAF functionality for Standard and Premium FD services. I can pull this down and submit with the module itself. I just didn't know if you wanted to vet the separately since it is a new add... |
|
@jartoo You can develop this dependency and module in a branch so that the purpose of the addition is clearer. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding azure-mgmt-frontdoor==1.2.0 (latest version) to enable future pull requests for Azure Frontdoor Web Application Framekwork
Continues to work on #1041 This does not complete this issue, yet.
ISSUE TYPE
COMPONENT NAME
Add azure-mgmt-frontdoor==1.2.0 to requirements.txt to enable Frontdoor WAF in future pull requests.
ADDITIONAL INFORMATION