Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_appgateway Add identity management to app gateway module #1598

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

p3ck
Copy link
Collaborator

@p3ck p3ck commented Jun 13, 2024

SUMMARY

Add the ability to specify managed identity for app gateway

Also the following:

  • fixed the code to handle proper idempotency.
  • Removed invalid test cases
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/azure_rm_appgateway.py
tests/integration/targets/azure_rm_appgateway/tasks/main.yml

ADDITIONAL INFORMATION

The compare_dict method skips etags to be able to determine if the content has changed.

@p3ck p3ck requested review from Fred-sun and nirarg June 13, 2024 22:37
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change request!

plugins/modules/azure_rm_appgateway.py Outdated Show resolved Hide resolved
@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Jun 17, 2024
@p3ck p3ck added the ready_for_review The PR has been modified and can be reviewed and merged label Jul 1, 2024
@xuzhang3 xuzhang3 merged commit 98ee0cb into ansible-collections:dev Jul 2, 2024
@xuzhang3 xuzhang3 changed the title Add identity management to app gateway module azure_rm_appgateway Add identity management to app gateway module Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants