Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support on_premises_extension_attributes to azure_rm_aduser #1518

Conversation

therapac
Copy link
Contributor

SUMMARY

Support on_premises_extension_attributes to azure_rm_aduser #1500

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_aduser.py
azure_rm_aduser_info.py
test targets > azure_rm_aduser > tasks: main

ADDITIONAL INFORMATION
DOCUMENTATION = '''
options:
    on_premises_extension_attributes:
        description:
            - Contains extensionAttributes1-15 for the user.
            - These extension attributes are also known as Exchange custom attributes 1-15.
            - For an onPremisesSyncEnabled user, the source of authority for this set of properties is the on-premises and is read-only.
            - For a cloud-only user (where onPremisesSyncEnabled is false), these properties can be set during the creation or update of a user object.
            - For a cloud-only user previously synced from on-premises Active Directory, these properties are read-only in Microsoft Graph but can be fully managed through the Exchange Admin Center or the Exchange Online V2 module in PowerShell.
        type: dict
        aliases:
            - extension_attributes

therapac and others added 2 commits March 28, 2024 13:11
            Add option: on_premises_extension_attributes
modified:   plugins/modules/azure_rm_aduser_info.py
	    Add option: on_premises_extension_attributes
modified:   tests/integration/targets/azure_rm_aduser/tasks/main.yml
	    Add option: on_premises_extension_attributes
            Fix: Domain name, password and username
plugins/modules/azure_rm_aduser.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser.py Outdated Show resolved Hide resolved
@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Mar 29, 2024
therapac and others added 4 commits April 2, 2024 15:58
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun
Copy link
Collaborator

Fred-sun commented Apr 3, 2024

@therapac Some formatting errors, please change. Thank you!
ERROR: plugins/modules/azure_rm_aduser.py:230:161: E501: line too long (241 > 160 characters)
ERROR: plugins/modules/azure_rm_aduser.py:323:41: E225: missing whitespace around operator
ERROR: plugins/modules/azure_rm_aduser.py:325:1: E101: indentation contains mixed spaces and tabs
ERROR: plugins/modules/azure_rm_aduser.py:325:1: W191: indentation contains tabs
ERROR: plugins/modules/azure_rm_aduser.py:325:20: E126: continuation line over-indented for hanging indent
ERROR: plugins/modules/azure_rm_aduser.py:327:1: E101: indentation contains mixed spaces and tabs
ERROR: plugins/modules/azure_rm_aduser.py:359:161: E501: line too long (211 > 160 characters)
ERROR: plugins/modules/azure_rm_aduser.py:440:5: E301: expected 1 blank line, found 0
ERROR: plugins/modules/azure_rm_aduser_info.py:152:161: E501: line too long (241 > 160 characters)
ERROR: plugins/modules/azure_rm_aduser_info.py:253:5: E301: expected 1 blank line, found 0
ERROR: plugins/modules/azure_rm_aduser_info.py:269:161: E501: line too long (167 > 160 characters)
ERROR: plugins/modules/azure_rm_aduser_info.py:277:161: E501: line too long (167 > 160 characters)

therapac and others added 2 commits April 4, 2024 07:31
modified:   plugins/modules/azure_rm_aduser_info.py
change formatting errors
Copy link
Contributor Author

@therapac therapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fred-sun I change the formatting errors with the sanity tests.

plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
therapac

This comment was marked as duplicate.

Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change request!

plugins/modules/azure_rm_aduser_info.py Show resolved Hide resolved
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors question Further information is requested labels Apr 8, 2024
@xuzhang3 xuzhang3 merged commit a7a0c55 into ansible-collections:dev Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants