Fix missing client_id in payload error when using only an Azure username and password #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmj251
changed the title
|
@kmj251 Thank you very much for your contribution, this is indeed a necessary modification! |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Jan 18, 2024
|
Any eta on a patch release as we hit this issue as well? |
|
@ericsysmin We can't confirm this yet, but we will release it as soon as possible. Thank you! |
|
Bug was introduced. credentialss is not valid |
ericsysmin
reviewed
Jan 25, 2024
| @@ -1491,7 +1491,9 @@ def __init__(self, auth_source=None, profile=None, subscription_id=None, client_ | |||
| authority=self._adfs_authority_url) | |||
|
|
|||
| elif self.credentials.get('ad_user') is not None and self.credentials.get('password') is not None: | |||
| client_id = self.credentials.get('client_id', '04b07795-8ddb-461a-bbee-02f9e1bf7b46') | |||
| client_id = self.credentialss.get('client_id') | |||
There was a problem hiding this comment.
client_id = self.credentialss.get('client_id')
needs to be
client_id = self.credentials.get('client_id')
|
@ericsysmin Thanks for catching that! I have a new PR to fix the typo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix code that does not set a default client_id correctly when only the ad_user and password are provided for authentication.
The code will now attempt to set the client_id to self.credentials.get('client_id'), if that value is
Nonebecause it was not passed in, it will set client_id to a default value.Fixes #1408
ISSUE TYPE
COMPONENT NAME
azure_rm_common.py
ADDITIONAL INFORMATION