-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure_rm_aduser
- Expose more password_profile
options: password_force_change
and password_force_change_mfa
#1376
Conversation
kindly ping! |
@pluto00987 Why do you have to redefine parameters that already exist? This has a large impact on the current user -- ‘password_profile'. You are advised not to change the previous parameter names. There is also a slight problem with the documentation. Thank you! |
@Fred-sun |
@pluto00987 This will affect the current user. In this case, please fix the problem described in the above document. As for changing the parameter name, we will discuss it internally. Thank you! |
@pluto00987 There are no other questions, please make changes to the above part of the document. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requests!
kindly ping! |
Kindly ping! |
…ns#1376) * Normalize 'password' vs 'password_profile' variable and option names * Add options for 'force password change on next logon'
Hello Fred-sun. |
…ns#1376) * Normalize 'password' vs 'password_profile' variable and option names * Add options for 'force password change on next logon'
Fred-sun, I made an error with the first rebase but have corrected it now. |
@xuzhang3 ready_for_review! |
@Fred-sun I see a problem. The So I will need to refactor this patch. I still don't like the name |
@pluto00987 Yes, you are right that it should not duplicate the integrated parameter name. After you resubmit, I will review and promote the merger as soon as possible! Thank you! |
…1376) * Add options for 'force password change on next logon' with or without MFA * Update some variable names from 'password' to 'password_profile' to improve code clarity
Hi @Fred-sun. I've updated the change. Please take a look now. Thank you! |
azure_rm_aduser
- Expose more password_profile
options: password_force_change
and password_force_change_mfa
SUMMARY
This adds two additional ansible options mapping to existing options within a user's passwordProfile attribute. Specifically for my use case, I needed to be able to set
forceChangePasswordNextSignIn=False
.passwordProfile resource type reference
Additionally, it normalizes the option and variable names so that 'password' is a password and 'password_profile' is a PasswordProfile object.
ISSUE TYPE
COMPONENT NAME
azure_rm_aduser
ADDITIONAL INFORMATION