Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the property for deprecating and renaming property #1294

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion plugins/modules/azure_rm_adpassword.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

description:
- Manage application password.
- The value property is deprecated in MS Graph API since this API will automatically generate the application password.

options:
app_id:
Expand All @@ -33,6 +32,7 @@
key_id:
description:
- The password key ID.
- It isn't supported anymore in the create operation. More details: https://learn.microsoft.com/en-us/graph/api/application-addpassword?view=graph-rest-1.0&tabs=http#request-body.
type: str
tenant:
description:
Expand All @@ -45,6 +45,11 @@
- Date or datemtime after which credentials expire.
- Default value is one year after current time.
type: str
value:
description:
- (deprecated) The application password value.
- Length greater than 18 characters.
type: str
display_name:
description:
- The friendly name of the application password.
Expand Down Expand Up @@ -138,6 +143,7 @@ def __init__(self):
app_object_id=dict(type='str'),
key_id=dict(type='str'),
tenant=dict(type='str', required=True),
value=dict(type='str'),
display_name=dict(type='str'),
end_date=dict(type='str'),
state=dict(type='str', default='present', choices=['present', 'absent']),
Expand All @@ -149,6 +155,7 @@ def __init__(self):
self.service_principal_object_id = None
self.app_object_id = None
self.key_id = None
self.value = None
self.display_name = None
self.end_date = None
self.results = dict(changed=False)
Expand All @@ -167,6 +174,9 @@ def exec_module(self, **kwargs):
if self.tenant:
self.deprecate('tenant ID has been deprecated and will be removed in the future. '
'More details: https://learn.microsoft.com/en-us/graph/migrate-azure-ad-graph-request-differences#example-request-comparison')
if self.value:
self.deprecate('value has been deprecated and will be removed in the future. '
'More details: https://learn.microsoft.com/en-us/graph/api/application-addpassword?view=graph-rest-1.0&tabs=http#request-body')

self._client = self.get_msgraph_client(self.tenant)
self.resolve_app_obj_id()
Expand Down
4 changes: 3 additions & 1 deletion plugins/modules/azure_rm_aduser.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
- The on_premises_immutable_id of the user.
- Used when either creating or updating a user account.
type: str
aliases:
- immutable_id
mail:
description:
- The primary email address of the user.
Expand Down Expand Up @@ -227,7 +229,7 @@ def __init__(self):
display_name=dict(type='str'),
password_profile=dict(type='str', no_log=True),
mail_nickname=dict(type='str'),
on_premises_immutable_id=dict(type='str'),
on_premises_immutable_id=dict(type='str', aliases=['immutable_id']),
usage_location=dict(type='str'),
given_name=dict(type='str'),
surname=dict(type='str'),
Expand Down