-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #1033 fix security profile for azure_rm_virtualmachine_info #1205
Merged
xuzhang3
merged 3 commits into
ansible-collections:dev
from
Klaas-:Klaas-fix_vm_security_profile
Jul 7, 2023
Merged
Refs #1033 fix security profile for azure_rm_virtualmachine_info #1205
xuzhang3
merged 3 commits into
ansible-collections:dev
from
Klaas-:Klaas-fix_vm_security_profile
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am guessing there is a problem in the rest api at the heart of this, but for the time being we have to deal with it :) |
Fred-sun
reviewed
Jul 5, 2023
Fix indentation Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Fix indentation Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Thanks for the review, I have to check why that was not done automatically by my IDE :) |
@Fred-sun do you use squash on merge or shall I squash it ? |
@Klaas- After my review, other developers will review and merge. Thank you! |
Fred-sun
added
ready_for_review
The PR has been modified and can be reviewed and merged
high_priority
High priority
labels
Jul 5, 2023
Klaas-
changed the title
Refs #1033 fix security profile for virtualimachine_info
Refs #1033 fix security profile for azure_rm_virtualmachine_info
Jul 5, 2023
xuzhang3
approved these changes
Jul 7, 2023
@Klaas- LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
high_priority
High priority
ready_for_review
The PR has been modified and can be reviewed and merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The output of the restapi for the VM does not always contain SecurityProfile, it furthermore only contains some information, I ran into an issue when enabling encryption_at_host, the API will then return:
and not the other keys that you expect in your code, so I made them all set-only-when-returned. I did not test if there are specific combinations that will always be set together, I do not use trusted launch/tpm in my env yet. I also changed the return value table to reflect that securityProfile is not always returned as well as the other values.
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine_info.py