Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery Services Vault #210

Closed
paultaiton opened this issue Jul 28, 2020 · 4 comments
Closed

Recovery Services Vault #210

paultaiton opened this issue Jul 28, 2020 · 4 comments
Labels
new_module_issue Request to add a new module

Comments

@paultaiton
Copy link
Contributor

paultaiton commented Jul 28, 2020 •
edited
Loading

SUMMARY

There is currently no module for Azure Recovery Services Vault.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_recoveryservicesvault
azure_rm_recoveryservicesvault_info

ADDITIONAL INFORMATION

The 2 modules (regular mutable and _info,) would be used to create, update, and lookup recovery services vaults in Azure.

azure_rm_recoveryservicesvault:
  name: pauls-recovery-vault
  location: westus
  sku:
    name: Standard
  resource_group: target-resource-group
  subscription_id: 00000000-0000-0000-0000-000000000000

azure_rm_recoveryservicesvault_info:
  resource_group: target-resource-group
  subscription_id: 00000000-0000-0000-0000-000000000000

I am planning on writing the modules myself, but wanted to post an Issue ahead of time to solicit feedback and comments, and to make sure no one else is already working on it.
@Fred-sun
Copy link
Collaborator

@paultaiton Thank you for submitting this question. This is a new module requirement. You are welcome to add these two modules? Thank you!

@Fred-sun Fred-sun added the new_module_issue Request to add a new module label Aug 5, 2020
@suyeb786
Copy link
Contributor

suyeb786 commented Sep 9, 2020

Hello @paultaiton ,
Let me know if you are working on it.
Else I will take this up.

suyeb786 pushed a commit to suyeb786/azure-234 that referenced this issue Sep 9, 2020
Resolved ansible-collections#210 Recovery Service Vault
85917b2
@suyeb786 suyeb786 mentioned this issue Sep 9, 2020
Merged
@paultaiton
Copy link
Contributor Author

paultaiton commented Sep 10, 2020 •
edited
Loading

@suyeb786
Nevermind on my previous commend, I hadn't realized you had already pushed a PR.

@paultaiton
Copy link
Contributor Author

Thanks @suyeb786 , awesome work. Really appreciate it.

haiyuazhang added a commit that referenced this issue Oct 26, 2020
@suyeb786 @Fred-sun @haiyuazhang
Azure Recovery Services VM Backup Policy (#271)
7d13133 
* Resolved #234

* Adjusted code as per review comments

* Updated the main.yaml file extension and registered module in pr-pipelines.yml

* Removed azure_rm_backupazurevm_info from pr-pipelines.yaml

* Updated meta/main.yaml to meta/main.yml

* removed meta/main.yaml

* Updated module with latest review comments

* Adjusted task/main.yml as per the recommendation

* Adjusted long string with column size 80

* Update azure_rm_backupazurevm_info.py

* Update azure_rm_backupazurevm_info.py

* Updated azure_rm_backupazurevm_info with latest review comments

* Updated tests/sanity/ignore-2.xx

* Udpated tests/sanity/ignore-2.xx

* Updated ignore-2.9.txt(removed lines 186-189) and tasks/main.yml(removed extra blank line)

* Resolved #210 Recovery Service Vault

* Adjusted the state and added provision for deleting RSV

* Updated Class Name

* Adjusted the code with latest review comments

* Added new line at end of aliases main.yml files

* Adjusted tasks/main.yml

* removed line no 3 from tasks/main.yml

* Read Recovery Vault Details Pre Creation Logic Integrated

* Added idempotent test and adjusted module return type

* Adjusted code as per review comments

* '2016-06-01' is required for create, delete as per official doc

* Adjusted code as per latest review comments

* Adjusted indentation

* Removed whitespace from line 175

* Added new module for VM Backup Policy #255

* Adjusted code as per review comments

* Added recovery vault testcases in policy module

* Documentation is updated

* Updated code as per review comments

* Updated sanity ignore files

* Updated tasks/main.yml

* Updated test cases

Co-authored-by: Suyeb Ansari <>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: haiyuan_zhang <haiyuan.zhang1982@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new_module_issue Request to add a new module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suyeb786 @Fred-sun @paultaiton