ec2_key / setup_sshkey - fix integration tests (OpenSSH 9.5) #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
approved these changes
Dec 3, 2024
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 32s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 54s |
softwarefactory-project-zuul
bot
merged commit 5a9d6aa
into
ansible-collections:main
46 checks passed
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #2407 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 5a9d6aa)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
…2407) This is a backport of PR #2406 as merged into main (5a9d6aa). SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
…-collections#2406) SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in ansible-collections#2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Jan 15, 2025
…-collections#2406) SUMMARY With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility). setup_sshkey now: Explicitly generates an 4096 bit RSA key (key_material) Generates the somewhat quirky md5sum based fingerprint AWS uses for RSA keys (fingerprint) Explicitly generates an ed25519 key (another_key_material) Pads the standard sha256 fingerprint to match the, technically correct, AWS format (another_fingerprint) ec2_key test now also checks the fingerprint of the second imported key. (Also fixes the issue seen in ansible-collections#2398 by switching ssh key generation back to the old 4096 bit RSA for key_material) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/setup_sshkey tests/integration/targets/ec2_key ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
With OpenSSH 9.5 the default format for SSH key generation was switched over to ed25519 (a good thing). However, some older OSes don't support ed25519 (eg the older image we use for testing ec2_metadata_facts python 2 compatibility).
setup_sshkey now:
key_material)fingerprint)another_key_material)another_fingerprint)ec2_key test now also checks the fingerprint of the second imported key.
(Also fixes the issue seen in #2398 by switching ssh key generation back to the old 4096 bit RSA for
key_material)ISSUE TYPE
COMPONENT NAME
tests/integration/targets/setup_sshkey
tests/integration/targets/ec2_key
ADDITIONAL INFORMATION