-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for host option in placement.tenancy #2026
add support for host option in placement.tenancy #2026
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
plugins/modules/ec2_instance.py
Outdated
@@ -362,7 +362,7 @@ | |||
description: Type of tenancy to allow an instance to use. Default is shared tenancy. Dedicated tenancy will incur additional charges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a note where you specify that support for host has been added in 7.6.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 8.0.0 instead since we are aiming for that to be the next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.0.0 makes sense if that's one we targeting next?
@alinabuzachis @hakbailey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we've released a final X-1 minor release at about the same time as the X major release. It gives us one last release of new features prior to the breaking changes that come with the major release and might cause folks to get stuck for a while (ie if they can't update Ansible-core or bump botocore for some reason)
6a0e256
to
111d200
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
111d200
to
d729d78
Compare
changelogs/fragments/2026-ec2_instance-add-support-for-placement-tenancy-host.yml
Outdated
Show resolved
Hide resolved
Pull request merge failed: Required status check "ansible/gate" is expected. |
55cac1c
to
79faee5
Compare
recheck |
096b026
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2061 🤖 @patchback |
add support for host option in placement.tenancy SUMMARY Add host option in tenancy under placement. Resolves #1990 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option. Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <hebailey@redhat.com> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Chappell (cherry picked from commit 096b026)
[PR #2026/096b0267 backport][stable-7] add support for host option in placement.tenancy This is a backport of PR #2026 as merged into main (096b026). SUMMARY Add host option in tenancy under placement. Resolves #1990 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option. Reviewed-by: Mark Chappell
SUMMARY
Add host option in tenancy under placement.
Resolves #1990
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.