Remove unused code #1996
Merged
Remove unused code #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@tremble Other than that, LGTM!
ERROR: tests/sanity/ignore-2.17.txt:1:1: ansible-test: Ignoring 'unparsable-with-libyaml' on 'plugins/inventory/aws_ec2.py' is unnecessary
alinabuzachis
approved these changes
Feb 27, 2024
|
@alinabuzachis sanity warning should go away once this is merged/rebased onto #1992 |
softwarefactory-project-zuul
bot
merged commit d8b0996
into
ansible-collections:main
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Various modules have been rewritten over the years and as a result there's now unused code that got left behind. This deletes some of the unused code.
ISSUE TYPE
COMPONENT NAME
autoscaling_group
cloudtrail
ec2_instance
ec2_vol
elb_classic_lb
kms_key
s3_object
ADDITIONAL INFORMATION