Add AWSRetries to ec2_vol standard boto3 calls #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
ec2_vol/retries
branch
from
bf34a21 to
db9c0c2
Compare
jillr
approved these changes
Nov 17, 2020
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tionStatus API Calls (ansible-collections#199) * Gracefully handle keys that don't allow kms:GetKeyRotationStatus API calls Some AWS KMS keys (e.g. aws/acm) do not allow permissions to call the API kms:GetKeyRotationStatus. As a result, module execution fails, even if the user execuing it has full admin privileges. Example: https://forums.aws.amazon.com/thread.jspa?threadID=312992 * change log fragment * Return None if key rotation status can't be determined Update documentation to reflect this use case. Use helper to track the exception. * Add integration tests
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…tionStatus API Calls (ansible-collections#199) * Gracefully handle keys that don't allow kms:GetKeyRotationStatus API calls Some AWS KMS keys (e.g. aws/acm) do not allow permissions to call the API kms:GetKeyRotationStatus. As a result, module execution fails, even if the user execuing it has full admin privileges. Example: https://forums.aws.amazon.com/thread.jspa?threadID=312992 * change log fragment * Return None if key rotation status can't be determined Update documentation to reflect this use case. Use helper to track the exception. * Add integration tests
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…tionStatus API Calls (ansible-collections#199) * Gracefully handle keys that don't allow kms:GetKeyRotationStatus API calls Some AWS KMS keys (e.g. aws/acm) do not allow permissions to call the API kms:GetKeyRotationStatus. As a result, module execution fails, even if the user execuing it has full admin privileges. Example: https://forums.aws.amazon.com/thread.jspa?threadID=312992 * change log fragment * Return None if key rotation status can't be determined Update documentation to reflect this use case. Use helper to track the exception. * Add integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Mitigate Rate-limiting errors with ec2_vol
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
CC: @falcon78921 - this is the AWSRetry changes I mentioned during review.