Minor Unit test and PEP8 sanity fixes (Ansible 2.16) #1846
Conversation
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 50s |
tremble
force-pushed
the
sanity/20231110
branch
from
df26e0b to
f65fed1
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 50s |
tremble
force-pushed
the
sanity/20231110
branch
from
f65fed1 to
7ae4218
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
sanity/20231110
branch
from
7ae4218 to
b186f5b
Compare
tremble
changed the title
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 30s |
|
There seems to be something broken in the Python-3.12/milestone test, since Python-3.12/devel and Python-3.11/milestone pass, I'm assuming this will go away next time milestone's updated... |
tremble
force-pushed
the
sanity/20231110
branch
from
b186f5b to
9c1709c
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 8m 40s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 8m 42s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1850 🤖 @patchback |
SUMMARY Addition of Ansible 2.16 has surfaced some new PEP8 issues: https://github.com/ansible-collections/amazon.aws/actions/runs/6822667301/job/18555114862?pr=1845 As well as exposing a 'broken' unit test (the test it was using didn't actually exist, it was only passing because we're using MagicMock which added a stub. Old versions of Python and Ansible have also been dropped by the upstream test, we don't need the include/exclude overrides any more. The latest versions of Python have also picked up on a bad unit test in ec2_ami_info. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance_snapshot autoscaling_group ec2_ami_info ADDITIONAL INFORMATION ==== * Minor PEP8 sanity fixes (Ansible 2.16) * Unit test fixes (cherry picked from commit 94bfa6f)
[PR #1846/94bfa6f1 backport][stable-7] Minor Unit test and PEP8 sanity fixes (Ansible 2.16) This is a backport of PR #1846 as merged into main (94bfa6f). SUMMARY Addition of Ansible 2.16 has surfaced some new PEP8 issues: https://github.com/ansible-collections/amazon.aws/actions/runs/6822667301/job/18555114862?pr=1845 As well as exposing a 'broken' unit test (the test it was using didn't actually exist, it was only passing because we're using MagicMock which added a stub. Old versions of Python and Ansible have also been dropped by the upstream test, we don't need the include/exclude overrides any more. The latest versions of Python have also picked up on a bad unit test in ec2_ami_info. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance_snapshot autoscaling_group ec2_ami_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY
Upstream's dropped support for Ansible 2.9 sanity tests, we don't need to mess about with our own include/exclude list any more.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
.github/workflows/sanity.yml
ADDITIONAL INFORMATION
See also ansible-collections/amazon.aws#1846
See also pycrypto/pycrypto@65b43bd (pycrypto / pycryptodome)
---
* Update sanity tests - upstream no longer supports ansible 2.9
* use defaults for units
* pycrypto doesn't work with recent versions - pycryptodome should be (mostly) compatible and uses the same namespace
SUMMARY
Upstream's dropped support for Ansible 2.9 sanity tests, we don't need to mess about with our own include/exclude list any more.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
.github/workflows/sanity.yml
ADDITIONAL INFORMATION
See also ansible-collections/amazon.aws#1846
See also pycrypto/pycrypto@65b43bd (pycrypto / pycryptodome)
---
* Update sanity tests - upstream no longer supports ansible 2.9
* use defaults for units
* pycrypto doesn't work with recent versions - pycryptodome should be (mostly) compatible and uses the same namespace
(cherry picked from commit 20521ee)
…#2003) [PR #1999/20521eec backport][stable-7] Update sanity tests - upstream no longer supports ansible 2.9 This is a backport of PR #1999 as merged into main (20521ee). SUMMARY Upstream's dropped support for Ansible 2.9 sanity tests, we don't need to mess about with our own include/exclude list any more. ISSUE TYPE Feature Pull Request COMPONENT NAME .github/workflows/sanity.yml ADDITIONAL INFORMATION See also ansible-collections/amazon.aws#1846 See also pycrypto/pycrypto@65b43bd (pycrypto / pycryptodome) Reviewed-by: Mark Chappell
Various ARN handling fixes Depends-On: ansible-collections#1619 SUMMARY fixes: ansible-collections#1846 Various modules had hard-coded ARN handling which assumed the use of the main partition. This causes problems for folks using Gov Cloud (and aws-cn) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/ec2_launch_template.py plugins/modules/elasticache_info.py plugins/modules/iam_group.py plugins/modules/iam_role.py plugins/modules/msk_config.py plugins/modules/redshift.py plugins/modules/sns_topic.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@25a636c
Various ARN handling fixes Depends-On: ansible-collections#1619 SUMMARY fixes: ansible-collections#1846 Various modules had hard-coded ARN handling which assumed the use of the main partition. This causes problems for folks using Gov Cloud (and aws-cn) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/ec2_launch_template.py plugins/modules/elasticache_info.py plugins/modules/iam_group.py plugins/modules/iam_role.py plugins/modules/msk_config.py plugins/modules/redshift.py plugins/modules/sns_topic.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@25a636c
Various ARN handling fixes Depends-On: ansible-collections#1619 SUMMARY fixes: ansible-collections#1846 Various modules had hard-coded ARN handling which assumed the use of the main partition. This causes problems for folks using Gov Cloud (and aws-cn) ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/batch_compute_environment.py plugins/modules/ec2_launch_template.py plugins/modules/elasticache_info.py plugins/modules/iam_group.py plugins/modules/iam_role.py plugins/modules/msk_config.py plugins/modules/redshift.py plugins/modules/sns_topic.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@25a636c
SUMMARY
Addition of Ansible 2.16 has surfaced some new PEP8 issues:
https://github.com/ansible-collections/amazon.aws/actions/runs/6822667301/job/18555114862?pr=1845
As well as exposing a 'broken' unit test (the test it was using didn't actually exist, it was only passing because we're using MagicMock which added a stub.
Old versions of Python and Ansible have also been dropped by the upstream test, we don't need the include/exclude overrides any more. The latest versions of Python have also picked up on a bad unit test in ec2_ami_info.
ISSUE TYPE
COMPONENT NAME
rds_instance_snapshot
autoscaling_group
ec2_ami_info
ADDITIONAL INFORMATION