Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda_info: remove unnecessary snake_casing of env_vars when querying lambda config #1457

Merged
merged 3 commits into from
Apr 18, 2023
Merged

lambda_info: remove unnecessary snake_casing of env_vars when querying lambda config #1457

merged 3 commits into from
Apr 18, 2023

Conversation

mandar242
Copy link
Contributor

SUMMARY

This PR modifies code to avoid converting environment variables to snake_case when querying config.
Fixes #1412

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lambda_info

ADDITIONAL INFORMATION

@mandar242 mandar242 requested a review from alinabuzachis April 7, 2023 20:11
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/11832982230747fa87b477d37f16f330

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 12m 21s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 16s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 06s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 25s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 27s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 36s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 48s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 11s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 24s
✔️ cloud-tox-py3 SUCCESS in 7m 14s
✔️ ansible-test-changelog SUCCESS in 4m 16s
✔️ ansible-test-splitter SUCCESS in 4m 53s
✔️ integration-amazon.aws-1 SUCCESS in 9m 59s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 18, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c391e15ad7074cf8b6f329ad8d26d5f9

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 12m 57s
✔️ ansible-test-splitter SUCCESS in 4m 46s
✔️ integration-amazon.aws-1 SUCCESS in 8m 46s
✔️ integration-community.aws-1 SUCCESS in 23m 16s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7afa27d into ansible-collections:main Apr 18, 2023
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Apr 26, 2023
@mandar242 @alinabuzachis
lambda_info: remove unnecessary snake_casing of env_vars when queryin…
cf8c790 
…g lambda config (ansible-collections#1457)

lambda_info: remove unnecessary snake_casing of env_vars when querying lambda config

SUMMARY

This PR modifies code to avoid converting environment variables to snake_case when querying config.
Fixes ansible-collections#1412

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

lambda_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 26, 2023
@alinabuzachis
lambda_info: remove unnecessary snake_casing of env_vars when queryin…
9f8f2ee 
…g lambda config (#1457) (#1479)

[manual backport stable-5] lambda_info: remove unnecessary snake_casing of env_vars when querying lambda config (#1457)

lambda_info: remove unnecessary snake_casing of env_vars when querying lambda config
SUMMARY
This PR modifies code to avoid converting environment variables to snake_case when querying config. Fixes #1412
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
Reviewed-by: Mark Chappell
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@mandar242 mandar242 deleted the lambda_info_snake_case_fix branch May 3, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda_info does not preserve environment variable names
2 participants
@mandar242 @tremble