Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] Bump botocore requirements #1342

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 24, 2023

SUMMARY

In line with our botocore version policy bump the minimum requirements

Starting with the 2.0.0 releases of amazon.aws and community.aws, it is generally the collection's policy to
support the versions of botocore and boto3 that were released 12 months prior to the most recent major
collection release, following semantic versioning (for example, 2.0.0, 3.0.0).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/module_utils/botocore.py
requirements.txt

ADDITIONAL INFORMATION

Based on a target release date for 6.0.0 of late April I've bumped this to botocore 1.25.0

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module_utils module_utils needs_triage plugins plugin (any type) tests tests labels Jan 24, 2023
@tremble tremble added this to the 6.0.0 milestone Jan 24, 2023
@softwarefactory-project-zuul

This comment was marked as resolved.

@ansibullbot
Copy link

@ansibullbot ansibullbot added the module module label Jan 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 37s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 38s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 30s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 12m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 02s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 48s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 10m 33s
✔️ cloud-tox-py3 SUCCESS in 6m 53s
✔️ ansible-test-changelog SUCCESS in 2m 22s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-amazon.aws-1 SUCCESS in 23m 24s
✔️ integration-amazon.aws-2 SUCCESS in 28m 46s
✔️ integration-amazon.aws-3 SUCCESS in 16m 52s
✔️ integration-amazon.aws-4 SUCCESS in 37m 57s
✔️ integration-amazon.aws-5 SUCCESS in 34m 45s
✔️ integration-amazon.aws-6 SUCCESS in 32m 36s
✔️ integration-amazon.aws-7 SUCCESS in 23m 33s
✔️ integration-amazon.aws-8 SUCCESS in 22m 36s
✔️ integration-amazon.aws-9 SUCCESS in 35m 54s
✔️ integration-amazon.aws-10 SUCCESS in 29m 46s
✔️ integration-amazon.aws-11 SUCCESS in 34m 03s
✔️ integration-amazon.aws-12 SUCCESS in 19m 54s
✔️ integration-amazon.aws-13 SUCCESS in 21m 06s
✔️ integration-amazon.aws-14 SUCCESS in 25m 46s
✔️ integration-amazon.aws-15 SUCCESS in 47m 27s
✔️ integration-amazon.aws-16 SUCCESS in 17m 14s
✔️ integration-amazon.aws-17 SUCCESS in 35m 50s
✔️ integration-amazon.aws-18 SUCCESS in 18m 42s
✔️ integration-amazon.aws-19 SUCCESS in 32m 18s
✔️ integration-amazon.aws-20 SUCCESS in 25m 16s
✔️ integration-amazon.aws-21 SUCCESS in 19m 46s
✔️ integration-amazon.aws-22 SUCCESS in 31m 01s
✔️ integration-community.aws-1 SUCCESS in 6m 09s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Jan 24, 2023
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 10, 2023
@tremble
Copy link
Contributor Author

tremble commented Feb 10, 2023

Based on a target release data for 6.0.0 of late April I've bumped this to botocore 1.25.0

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

@tremble tremble marked this pull request as ready for review February 10, 2023 10:42
@tremble
Copy link
Contributor Author

tremble commented Feb 10, 2023

@alinabuzachis partly as a straw man, I've based these versions off a 'late April' release date for 6.0.0. How do you feel about aiming for a "late April" release date for 6.0.0. Cut-off for Ansible-8 inclusion looks like it'll be mid-May

@alinabuzachis
Copy link
Collaborator

@alinabuzachis partly as a straw man, I've based these versions off a 'late April' release date for 6.0.0. How do you feel about aiming for a "late April" release date for 6.0.0. Cut-off for Ansible-8 inclusion looks like it'll be mid-May

I'll discuss with the team and let you know.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 17, 2023
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble tremble force-pushed the 6.0.0/botocore branch 2 times, most recently from 676367e to 6f27ccc Compare February 18, 2023 09:08
@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented Feb 20, 2023

recheck

@softwarefactory-project-zuul

This comment was marked as outdated.

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented Feb 21, 2023

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2932ab4b62bd42ecb7b4e028fbf845f2

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 13m 10s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 01s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 16m 03s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 53s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 32s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 46s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 32s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 15s
✔️ cloud-tox-py3 SUCCESS in 10m 16s
✔️ ansible-test-changelog SUCCESS in 6m 44s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 20m 43s
✔️ integration-amazon.aws-2 SUCCESS in 30m 10s
✔️ integration-amazon.aws-3 SUCCESS in 21m 40s
✔️ integration-amazon.aws-4 SUCCESS in 41m 52s
✔️ integration-amazon.aws-5 SUCCESS in 41m 50s
✔️ integration-amazon.aws-6 SUCCESS in 31m 35s
✔️ integration-amazon.aws-7 SUCCESS in 21m 34s
✔️ integration-amazon.aws-8 SUCCESS in 23m 30s
✔️ integration-amazon.aws-9 SUCCESS in 39m 52s
✔️ integration-amazon.aws-10 SUCCESS in 32m 43s
✔️ integration-amazon.aws-11 SUCCESS in 33m 57s
✔️ integration-amazon.aws-12 SUCCESS in 20m 52s
✔️ integration-amazon.aws-13 SUCCESS in 26m 05s
✔️ integration-amazon.aws-14 SUCCESS in 26m 04s
✔️ integration-amazon.aws-15 SUCCESS in 25m 10s
✔️ integration-amazon.aws-16 SUCCESS in 18m 47s
✔️ integration-amazon.aws-17 SUCCESS in 31m 16s
✔️ integration-amazon.aws-18 SUCCESS in 21m 34s
✔️ integration-amazon.aws-19 SUCCESS in 51m 09s
✔️ integration-amazon.aws-20 SUCCESS in 26m 23s
✔️ integration-amazon.aws-21 SUCCESS in 29m 25s
✔️ integration-amazon.aws-22 SUCCESS in 16m 21s
✔️ integration-community.aws-1 SUCCESS in 7m 19s
Skipped 21 jobs

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label Feb 21, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/621b296a6d6a4c3aaf5c8ae407756748

✔️ ansible-galaxy-importer SUCCESS in 3m 46s
✔️ build-ansible-collection SUCCESS in 12m 26s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 16m 58s
✔️ integration-amazon.aws-2 SUCCESS in 27m 52s
✔️ integration-amazon.aws-3 SUCCESS in 24m 13s
✔️ integration-amazon.aws-4 SUCCESS in 39m 40s
✔️ integration-amazon.aws-5 SUCCESS in 42m 10s
✔️ integration-amazon.aws-6 SUCCESS in 36m 07s
✔️ integration-amazon.aws-7 SUCCESS in 26m 18s
✔️ integration-amazon.aws-8 SUCCESS in 26m 58s
✔️ integration-amazon.aws-9 SUCCESS in 39m 15s
✔️ integration-amazon.aws-10 SUCCESS in 41m 07s
✔️ integration-amazon.aws-11 SUCCESS in 38m 34s
✔️ integration-amazon.aws-12 SUCCESS in 18m 51s
✔️ integration-amazon.aws-13 SUCCESS in 24m 41s
✔️ integration-amazon.aws-14 SUCCESS in 24m 12s
✔️ integration-amazon.aws-15 SUCCESS in 23m 46s
✔️ integration-amazon.aws-16 SUCCESS in 21m 00s
✔️ integration-amazon.aws-17 SUCCESS in 35m 26s
✔️ integration-amazon.aws-18 SUCCESS in 19m 52s
✔️ integration-amazon.aws-19 SUCCESS in 31m 58s
✔️ integration-amazon.aws-20 SUCCESS in 30m 24s
✔️ integration-amazon.aws-21 SUCCESS in 37m 58s
✔️ integration-amazon.aws-22 SUCCESS in 18m 30s
✔️ integration-community.aws-1 SUCCESS in 6m 45s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 95b1f08 into ansible-collections:main Feb 21, 2023
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Mar 13, 2023
[6.0.0] Bump botocore requirements

SUMMARY
In line with our botocore version policy bump the minimum requirements

Starting with the 2.0.0 releases of amazon.aws and community.aws, it is generally the collection's policy to
support the versions of botocore and boto3 that were released 12 months prior to the most recent major
collection release, following semantic versioning (for example, 2.0.0, 3.0.0).

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
requirements.txt
ADDITIONAL INFORMATION

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

See also ansible-collections/amazon.aws#1342

Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
[6.0.0] Bump botocore requirements

SUMMARY
In line with our botocore version policy bump the minimum requirements

Starting with the 2.0.0 releases of amazon.aws and community.aws, it is generally the collection's policy to
support the versions of botocore and boto3 that were released 12 months prior to the most recent major
collection release, following semantic versioning (for example, 2.0.0, 3.0.0).

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
requirements.txt
ADDITIONAL INFORMATION

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

See also ansible-collections#1342

Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
[6.0.0] Bump botocore requirements

SUMMARY
In line with our botocore version policy bump the minimum requirements

Starting with the 2.0.0 releases of amazon.aws and community.aws, it is generally the collection's policy to
support the versions of botocore and boto3 that were released 12 months prior to the most recent major
collection release, following semantic versioning (for example, 2.0.0, 3.0.0).

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
requirements.txt
ADDITIONAL INFORMATION

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

See also ansible-collections#1342

Reviewed-by: Alina Buzachis
@tremble tremble deleted the 6.0.0/botocore branch September 27, 2023 06:59
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 18, 2024
[6.0.0] Bump botocore requirements

SUMMARY
In line with our botocore version policy bump the minimum requirements

Starting with the 2.0.0 releases of amazon.aws and community.aws, it is generally the collection's policy to
support the versions of botocore and boto3 that were released 12 months prior to the most recent major
collection release, following semantic versioning (for example, 2.0.0, 3.0.0).

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
requirements.txt
ADDITIONAL INFORMATION

boto3 - 1.22.0 - "Mon Apr 25 18:07:20 2022 +0000"
botocore - 1.25.0 - "Mon Apr 25 18:07:02 2022 +0000"

See also ansible-collections#1342

Reviewed-by: Alina Buzachis

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4baf1cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants