-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible AWS User-Agent identification #1306
Ansible AWS User-Agent identification #1306
Conversation
864d332
to
96c3915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abikouo,
I've been poking about with some of the botocore.config.Config() logic over in #1305 I'd recommend minimising the change you make here to the Config and only tweak the User Agent piece - currently writing some unit tests. This botocore code is something we really should have unit tests for.
Just a note that I'm going to add something to the backlog to come up with a way to automate incrementing the version variable. Manually editing for releases should be a very short-term process. |
Do we have anywhere to document things like the release process? I've got a few things for the major release / branching process I'd like to see documented, and this adds a new little gotcha for the general release process |
@tremble No, we do not have at the moment. It would be awesome to have this documentation for the release process. What do you thing about adding a new dedicated doc under the |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
SUMMARY
The value will be similar to this
APN/1.0 Ansible/2.14.1 amazon.aws/6.0.0-dev0
ISSUE TYPE