ec2_key/tests: add unit-tests #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
module
tremble
previously requested changes
Nov 29, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
alinabuzachis
approved these changes
Dec 6, 2022
goneri
dismissed
tremble’s stale review
I believe all the points have been addressed.
1 task
abikouo
added
backport-4
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1380 🤖 @patchback |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1381 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
ec2_key/tests: add unit-tests SUMMARY Add the unit-test coverage of the ec2_key module. Refactor the module to reduce complexity and allow unit testing. COMPONENT NAME ec2_key Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html Reviewed-by: Mark Chappell <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 7e14dcf)
patchback bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
ec2_key/tests: add unit-tests SUMMARY Add the unit-test coverage of the ec2_key module. Refactor the module to reduce complexity and allow unit testing. COMPONENT NAME ec2_key Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html Reviewed-by: Mark Chappell <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 7e14dcf)
This was referenced Feb 21, 2023
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
[PR #1288/7e14dcf0 backport][stable-4] ec2_key/tests: add unit-tests This is a backport of PR #1288 as merged into main (7e14dcf). SUMMARY Add the unit-test coverage of the ec2_key module. Refactor the module to reduce complexity and allow unit testing. COMPONENT NAME ec2_key Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html Reviewed-by: Mark Chappell
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
[PR #1288/7e14dcf0 backport][stable-5] ec2_key/tests: add unit-tests This is a backport of PR #1288 as merged into main (7e14dcf). SUMMARY Add the unit-test coverage of the ec2_key module. Refactor the module to reduce complexity and allow unit testing. COMPONENT NAME ec2_key Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename api_gateway modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_api_gateway and aws_api_gateway_domain. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_api_gateway.py plugins/modules/aws_api_gateway_domain.py plugins/modules/api_gateway.py plugins/modules/api_gateway_domain.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename api_gateway modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_api_gateway and aws_api_gateway_domain. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_api_gateway.py plugins/modules/aws_api_gateway_domain.py plugins/modules/api_gateway.py plugins/modules/api_gateway_domain.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 20, 2023
Rename api_gateway modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_api_gateway and aws_api_gateway_domain. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_api_gateway.py plugins/modules/aws_api_gateway_domain.py plugins/modules/api_gateway.py plugins/modules/api_gateway_domain.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@2caa275
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Rename api_gateway modules SUMMARY In line with the naming guidelines, removes the aws_ prefix from aws_api_gateway and aws_api_gateway_domain. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_api_gateway.py plugins/modules/aws_api_gateway_domain.py plugins/modules/api_gateway.py plugins/modules/api_gateway_domain.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
COMPONENT NAME
ec2_key
Latest unit-test coverage (86%): https://890cb34819f4a5031a6a-ac7bf798a2c5290001623a42300937df.ssl.cf5.rackcdn.com/1288/8f1100d82dc058131d0476ff7f82ee7f6eac5b7b/check/cloud-tox-py3/8b0e4b4/docs/coverage/plugins_modules_ec2_key_py.html