ec2_security_group - refacter get_target_from_rule() #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
refacter/ec2_security_group/get_target_from_rule
branch
3 times, most recently
from
0d79a09 to
cfeb5ab
Compare
tremble
force-pushed
the
refacter/ec2_security_group/get_target_from_rule
branch
from
cfeb5ab to
afc3efd
Compare
alinabuzachis
approved these changes
Nov 2, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#1221) aws_codebuild - Add resource_tags parameter and deprecate tags SUMMARY aws_codebuild currently uses the boto3 style 'list of dictionaries' format rather than the usual dictionary format. Add a resource_tags parameter that accepts the usual dictionary format Add the purge_tags parameter deprecate the tags parameter in preparation for switching it to the usual dict format expand integration tests for tags and description make source and artifacts optional unless creating a new project fix bug with inconsistent "changed" state due to tag order not being guaranteed ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME aws_codebuild ADDITIONAL INFORMATION The (boto3) tags format in the return value when describing a project makes no guarantees about the order it'll return the key/value pairs. As such, when multiple tags were set the naïve original == new comparison would sporadically return "changed" when no change had occurred. Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… list of dicts (ansible-collections#1643) [6.0.0] codebuild_project - update tags param to use dict rather than list of dicts SUMMARY Passing list of dicts was deprecated, move it to dict fixes: ansible-collections#1546 Originally deprecated in ansible-collections#1221 as part of the tagging cleanup. ISSUE TYPE Feature Pull Request COMPONENT NAME codebuild_project ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#1221) aws_codebuild - Add resource_tags parameter and deprecate tags SUMMARY aws_codebuild currently uses the boto3 style 'list of dictionaries' format rather than the usual dictionary format. Add a resource_tags parameter that accepts the usual dictionary format Add the purge_tags parameter deprecate the tags parameter in preparation for switching it to the usual dict format expand integration tests for tags and description make source and artifacts optional unless creating a new project fix bug with inconsistent "changed" state due to tag order not being guaranteed ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME aws_codebuild ADDITIONAL INFORMATION The (boto3) tags format in the return value when describing a project makes no guarantees about the order it'll return the key/value pairs. As such, when multiple tags were set the naïve original == new comparison would sporadically return "changed" when no change had occurred. Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
… list of dicts (ansible-collections#1643) [6.0.0] codebuild_project - update tags param to use dict rather than list of dicts SUMMARY Passing list of dicts was deprecated, move it to dict fixes: ansible-collections#1546 Originally deprecated in ansible-collections#1221 as part of the tagging cleanup. ISSUE TYPE Feature Pull Request COMPONENT NAME codebuild_project ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…le-collections#1221) aws_codebuild - Add resource_tags parameter and deprecate tags SUMMARY aws_codebuild currently uses the boto3 style 'list of dictionaries' format rather than the usual dictionary format. Add a resource_tags parameter that accepts the usual dictionary format Add the purge_tags parameter deprecate the tags parameter in preparation for switching it to the usual dict format expand integration tests for tags and description make source and artifacts optional unless creating a new project fix bug with inconsistent "changed" state due to tag order not being guaranteed ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME aws_codebuild ADDITIONAL INFORMATION The (boto3) tags format in the return value when describing a project makes no guarantees about the order it'll return the key/value pairs. As such, when multiple tags were set the naïve original == new comparison would sporadically return "changed" when no change had occurred. Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
… list of dicts (ansible-collections#1643) [6.0.0] codebuild_project - update tags param to use dict rather than list of dicts SUMMARY Passing list of dicts was deprecated, move it to dict fixes: ansible-collections#1546 Originally deprecated in ansible-collections#1221 as part of the tagging cleanup. ISSUE TYPE Feature Pull Request COMPONENT NAME codebuild_project ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
refacter get_target_from_rule to bring down the complexity score
Builds on top of #1214
ISSUE TYPE
COMPONENT NAME
ec2_security_group
ADDITIONAL INFORMATION