Linting cleanup #1181
Merged
Linting cleanup #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
sanity/2022-10-18
branch
2 times, most recently
from
bb33e07 to
6a056f0
Compare
alinabuzachis
approved these changes
Oct 18, 2022
tremble
added
mergeit
tremble
force-pushed
the
sanity/2022-10-18
branch
from
6a056f0 to
a79eeee
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
goneri
approved these changes
Oct 18, 2022
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply e3f091e on top of patchback/backports/stable-5/e3f091e620c96c0dddd12fda16fb0dae4389ee19/pr-1181 Backporting merged PR #1181 into main
🤖 @patchback |
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Oct 28, 2022
Partial backport of ansible-collections#1181 ##### SUMMARY Minor linting cleanup missing whitespace ##### ISSUE TYPE Feature Pull Request ##### COMPONENT NAME plugins/inventory/aws_ec2.py plugins/modules/s3_object_info.py ##### ADDITIONAL INFORMATION Original Reviews: Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 28, 2022
Backport Linting cleanup from 1181 Partial backport of #1181 SUMMARY Minor linting cleanup missing whitespace ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/modules/s3_object_info.py ADDITIONAL INFORMATION Original Reviews: Reviewed-by: Alina Buzachis Reviewed-by: Gonéri Le Bouder Reviewed-by: Alina Buzachis <None>
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Oct 28, 2022
Backport Linting cleanup from 1181 Partial backport of ansible-collections#1181 SUMMARY Minor linting cleanup missing whitespace ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/inventory/aws_ec2.py plugins/modules/s3_object_info.py ADDITIONAL INFORMATION Original Reviews: Reviewed-by: Alina Buzachis Reviewed-by: Gonéri Le Bouder Reviewed-by: Alina Buzachis <None>
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_service -- Capacity provider strategy SUMMARY Fixes ansible-collections#1137 Per request, allow for the user to provide a capacity_provider_strategy when creating or updating an ECS service. This capacity_provider_strategy is a list of 1-6 dictionaries. The new capacity_provider_strategy is mutually exclusive with launch_type and an existing service cannot be changed from one to the other. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The new parameter is optional and non-default. If neither launch_type or capacity_provider_strategy are provided, the new service will default to EC2 launch_type. The module handles the mutually exclusivity and also catches and fails cleanly when trying to change an existing service from launch_type to capacity_provider_strategy or vice versa. Tested pretty thoroughly against ansible 2.9.27. Updated parameters, examples, and return objects provided. Before merge the module will just ignore the capacity_provider_strategy and default to EC2 launch_type. After merge the module will handle either launch_type or capacity_provider_strategy and create/update the service as necessary. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 1 capacity_provider_strategy: - capacity_provider: test-capacity-provider-1 weight: 1 base: 0 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
ecs_service -- Capacity provider strategy SUMMARY Fixes ansible-collections#1137 Per request, allow for the user to provide a capacity_provider_strategy when creating or updating an ECS service. This capacity_provider_strategy is a list of 1-6 dictionaries. The new capacity_provider_strategy is mutually exclusive with launch_type and an existing service cannot be changed from one to the other. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The new parameter is optional and non-default. If neither launch_type or capacity_provider_strategy are provided, the new service will default to EC2 launch_type. The module handles the mutually exclusivity and also catches and fails cleanly when trying to change an existing service from launch_type to capacity_provider_strategy or vice versa. Tested pretty thoroughly against ansible 2.9.27. Updated parameters, examples, and return objects provided. Before merge the module will just ignore the capacity_provider_strategy and default to EC2 launch_type. After merge the module will handle either launch_type or capacity_provider_strategy and create/update the service as necessary. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 1 capacity_provider_strategy: - capacity_provider: test-capacity-provider-1 weight: 1 base: 0 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
ecs_service -- Capacity provider strategy SUMMARY Fixes ansible-collections#1137 Per request, allow for the user to provide a capacity_provider_strategy when creating or updating an ECS service. This capacity_provider_strategy is a list of 1-6 dictionaries. The new capacity_provider_strategy is mutually exclusive with launch_type and an existing service cannot be changed from one to the other. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The new parameter is optional and non-default. If neither launch_type or capacity_provider_strategy are provided, the new service will default to EC2 launch_type. The module handles the mutually exclusivity and also catches and fails cleanly when trying to change an existing service from launch_type to capacity_provider_strategy or vice versa. Tested pretty thoroughly against ansible 2.9.27. Updated parameters, examples, and return objects provided. Before merge the module will just ignore the capacity_provider_strategy and default to EC2 launch_type. After merge the module will handle either launch_type or capacity_provider_strategy and create/update the service as necessary. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 1 capacity_provider_strategy: - capacity_provider: test-capacity-provider-1 weight: 1 base: 0 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor linting cleanup
in kms_key also replaces
get_account_infowithmodule_utils.iam.get_aws_account_infoISSUE TYPE
COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/module_utils/cloud.py
plugins/modules/autoscaling_group.py
plugins/modules/cloudtrail_info.py
plugins/modules/cloudwatchlogs_log_group.py
plugins/modules/ec2_eip.py
plugins/modules/kms_key_info.py
plugins/modules/lambda.py
plugins/modules/lambda_execute.py
plugins/modules/rds_cluster_snapshot.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/route53_health_check.py
plugins/modules/s3_object_info.py
ADDITIONAL INFORMATION