Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_nat_gateway should support creating nat gateway with connectivity = private #1260

Closed
1 task done
jsalatiel opened this issue Nov 3, 2022 · 5 comments · Fixed by #1267
Closed
1 task done

ec2_vpc_nat_gateway should support creating nat gateway with connectivity = private #1260

jsalatiel opened this issue Nov 3, 2022 · 5 comments · Fixed by #1267
Assignees
@GomathiselviS
Labels
feature This issue/PR relates to a feature request jira module module plugins plugin (any type)

Comments

@jsalatiel
Copy link

jsalatiel commented Nov 3, 2022 •
edited
Loading

Summary

Currently the module always allocates an elastic IP and set the connectivity type for the natgw to public.

It should be possible to set the connectivity type to private and not allocate any elastic/public IP to it. Just like it can be done manually.

Issue Type

Feature Idea

Component Name

ec2_vpc_nat_gateway

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:

None


If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  needs_triage


  labels


      Nov 3, 2022

    

  








      

  
      



  

  @jsalatiel





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  Author


  


  

    

  





      


        


  
    

      
          
!component +plugins/modules/ec2_vpc_nat_gateway.py

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @markuman @s-hertel @tremble

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  module

  module

      

  plugins

  plugin (any type)

  labels


      Nov 3, 2022

    

  



    

    

      
    

    


      

          @alinabuzachis
alinabuzachis




        transferred this issue from ansible-collections/community.aws


      Nov 10, 2022

    

  








      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @Etherdaemon @alinabuzachis @jonhadfield @linuxdynasty

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @GomathiselviS
GomathiselviS




              self-assigned this


      Nov 14, 2022

    

  



    


  

  

    
  


  

      

    @GomathiselviS
GomathiselviS



    mentioned this issue
    
      Nov 15, 2022
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Nov 15, 2022
    
    

      


  

    

      


  

      
        @GomathiselviS
  





      

        
          ec2_vpc_nat_gateway: Add support for connectivity_type = private (#1267)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          c1f7ad3
        
      

    

  

    

      
ec2_vpc_nat_gateway: Add support for connectivity_type = private

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


Fixes: #1260
This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: GomathiselviS <None>

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      pushed a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      Apr 27, 2023
    
    

      


  

    

      


  

      
        @GomathiselviS
      
        @alinabuzachis
  





      

        
          ec2_vpc_nat_gateway: Add support for connectivity_type = private (ans…
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          a012623
        
      

    

  

    

      
…ible-collections#1267)

ec2_vpc_nat_gateway: Add support for connectivity_type = private

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


Fixes: ansible-collections#1260
This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: GomathiselviS <None>

    




    

  




  

  

    
  


  

      

    @alinabuzachis
alinabuzachis



    mentioned this issue
    
      Apr 27, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Apr 28, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          ec2_vpc_nat_gateway: Add support for connectivity_type = private (#1267…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          6fd01a6
        
      

    

  

    

      
…) (#1486)

[manual backport stable-5] ec2_vpc_nat_gateway: Add support for connectivity_type = private (#1267)

ec2_vpc_nat_gateway: Add support for connectivity_type = private
Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY
Fixes: #1260
This PR adds a key 'connectivity_type' to ec2_vpc_nat_gateway module ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Mandar Kulkarni mandar242@gmail.com
Reviewed-by: Gonéri Le Bouder goneri@lebouder.net
Reviewed-by: GomathiselviS 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @GomathiselviS
  
    GomathiselviS
    

      








      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    jira

  

    module

  module
  

    plugins

  plugin (any type)








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      ec2_vpc_nat_gateway: Add support for connectivity_type = private

    
      GomathiselviS/amazon.aws
    





    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @jsalatiel 
        
          @GomathiselviS 
        
          @ansibullbot