Update dom parsing and fix some elements not bolded and broken buttons #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old code had inconsistent if else logic which also added .br-bold to all br-elements
X140Yu
reviewed
May 29, 2022
Co-authored-by: Xinyu <zhaoxinyu1994@gmail.com>
|
@asieduernest12 LGTM, but there are some conflicts, you can resolve first and try to merge yourself |
X140Yu
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@X140Yu @ansh kindly take a look
fixes #71
#45
fixed #57
before
after
fix #55
fix #43 reporter should test this
fix #36
fix #27 only for elements already on the screen. elements loaded dynamically through js are not bolded
fix #87