added feature to control the density of saccades which is also persisted #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y numeric value persisted for resuse
|
#39 only saccades fixed with this
|
X140Yu
reviewed
May 24, 2022
There was a problem hiding this comment.
Hi @asieduernest12 , left a few comments, overall the PR looks pretty solid
PS. there are some formatting issues, can do an npm install and use ESLint to format changes
dingxuanyao
approved these changes
May 24, 2022
dingxuanyao
reviewed
May 24, 2022
|
Thanks @asieduernest12 @dingxuanyao ! |
asieduernest12
added a commit
that referenced
this pull request
Dec 26, 2024
fix(ci): bugs zipping opera, add time delay to stabilize parallel bui…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change includes adding buttons to popup.html , and updates to css in convert.js
the saccades rendered on the screen is controlled by setting an attribute on the body element which cause the right css to take over the styling br-bold elements
the initial saccades value (interval or gap between saccades) is 2 which is persisted when changed with the buttons
