Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #206: Translation file field name typo ("Hieght" -> "Height") #208

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

gypsicoder
Copy link

This is my first contribution in the repo. It's very small part.
Please let me know is the commit okay or not.

Thank you for giving time on reviewing the PR.

@asieduernest12
Copy link
Collaborator

asieduernest12 commented Feb 20, 2023

Commit it fine, normally keep the conversation messages relevant to the changes or a little humor for the algorithm lords.
Would have been nice to include a note that said you already updated the ui files to pickup the updated fields. So anyone checking is freed from doing the mental calculations to land a space x rocket of which files they have to check although we are still going to just use the commit tab to look through the changes.

Nice commit.
MoonsdaoRocketGIF

Fixes issue #206

@asieduernest12 asieduernest12 merged commit b283fff into ansh:master Feb 20, 2023
@gypsicoder
Copy link
Author

@asieduernest12
Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants