Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work correctly on google drive nor any online pdf readers #20

Closed
Sininejuust opened this issue May 22, 2022 · 15 comments
Closed

Doesn't work correctly on google drive nor any online pdf readers #20

Sininejuust opened this issue May 22, 2022 · 15 comments
Labels
enhancement New feature or request FAQ

Comments

@Sininejuust
Copy link

I was planning on using it to help me better read school notes on google docs, but it only transforms the name of the document and the drop-down lists, but not the main body of the text :(
@tzazixten
Copy link

Just made an account to say this. I would love support for pdf files as well !

@ansh
Copy link
Owner

ansh commented May 23, 2022

Unfortunately getting it to work on Google Docs and on PDFs is extremely difficult (via a chrome extension, easy if it were a separate website)

@tzazixten
Copy link

Ah damn. Fair enough. But I think there would be lots of interest for a tool like this to be able to read pdf files, as that is the format 90% of difficult texts I read is in. If some people are up for the task, it would be highly appreciated:)

@jnk-klver
Copy link

A way to make that possible right now is converting the pdf in html and open it in your browser. That should work, but it's probably gonna weird

@tzazixten
Copy link

tzazixten commented May 24, 2022 •
edited
Loading

I just tried converting 5 different pdf files, and it doesn't really work. Only on italics, and other small bits, for some reason. I think it is because of the way the text is written in pdf (converted to html), that must be different to normal html (obviously, I guess, I'm not really a programmer). Perhaps to avoid misuse of copyrighted books or something.

When you F12 and inspect element it looks like this in my pdf converted to html. I hope it helps somebody:

image

image

  • And another one like this:

image

image

  • And here it works for a small part of the text, but it creates weird spaces in the middle of the words too

image

image

  • I hope this is useful info, for the right person.

@ansh ansh added the enhancement New feature or request label May 29, 2022
@reaseno
Copy link

reaseno commented Jun 27, 2022

I converted my PDF to HTML and it only works when I put it on a web server. Why doesn't it work with a local HTML file?

@rahilwazir
Copy link

rahilwazir commented Jun 29, 2022 •
edited
Loading

@reaseno

I converted my PDF to HTML and it only works when I put it on a web server. Why doesn't it work with a local HTML file?

Because the extension only works for the http(s):// protocol. I think adding a file:// should do the trick if I'm not mistaken.

@reaseno
Copy link

reaseno commented Jun 30, 2022

Doesn't sound like it would be a complicated fix 🤔

@ansh
Copy link
Owner

ansh commented Jun 30, 2022 via email

@asieduernest12
Copy link
Collaborator

@reaseno try the extension with your local files again.
Can you share the process you took to convert your pdf?

@reaseno
Copy link

reaseno commented Aug 7, 2022

I used this for conversion:
https://cloudconvert.com

@asieduernest12
Copy link
Collaborator

I used this for conversion: https://cloudconvert.com

i was able to convert a pdf to epub
uploaded the epub to google play books
able to read it with jiffyreader

i am guessing this all works provided the pdf version is storing actual text because there are many versions of the pdf specification.

Some specs support text while others are intented for storing images in varying resolutions.
If the pdf is in the image specification then probably this will not work

@reaseno
Copy link

reaseno commented Aug 8, 2022

@asieduernest12
I tried again with a local HTML file. Now the extension says:
Tabs without a url may not work properly
Reload the tab with valid url and try again.

Then I enabled "Allow access to file URLs" in the browser for the extension. After that, jiffyreader worked with that local file. I had already tried this on June 27, where it still did not work. If there was a fix, thank you very much.

@asieduernest12
Copy link
Collaborator

asieduernest12 commented Aug 8, 2022 •
edited
Loading

@reaseno super interesting so now it seems we have solved the issues with not being able to read pdfs.
I totally forgot about enabling the extension to access file url when i was testing.

so you can use cloudconvert.com to convert a pdf to html and view it right in the browser. With the second option being converting to an epub and uploading to google play which means you can technically read it anywhere from any other browser.

a nice feature then would be read a pdf which would handle the upload and conversion seemlessly and then showing the result as jiffied text.

@ansh @X140Yu @jhonalino

@asieduernest12
Copy link
Collaborator

@asieduernest12 I tried again with a local HTML file. Now the extension says: Tabs without a url may not work properly Reload the tab with valid url and try again.

Then I enabled "Allow access to file URLs" in the browser for the extension. After that, jiffyreader worked with that local file. I had already tried this on June 27, where it still did not work. If there was a fix, thank you very much.
TheUniverseTimAndEricMindBlownGIF
PeaceOutIceAgeGIF

asieduernest12 added a commit that referenced this issue Sep 2, 2023
@asieduernest12
enableReproducibleBuilds (#277)
99a07bc 
* Update: include version params to welcome page (#12)

* Hotfix/oninstallbug (#13)

* Update: include version params to welcome page

* Fix: logic error opening welcome page always on production install events

* Feat: make and push tags with make (#14)

* Update: package.json description (#15)

* Update: Make scripts

* Update(dev): simply action.sh and simplify its call to just a single line with default parameters to be called for building all browser targets except safari

* Update(dev): call action.sh in github actions

* Update/make tag scripts (#16)

* Update(dev): drop development tag actions

* Chore: make bumped version to: 1.1.0

* Fix/GitHub actions (#17)

* Fix: add engine to force node 18 engine on githubActions

* Update(dev): use node@18.12.1 in actions

* Update: fix env Name quotes

* Chore: fix quoting

* Fix: broken build by removing engine in package.json

* Chore(dev):  formating

* Update(dev): add make build@latest

* Fix: actions.sh scope echo

* Update: github action to call make build@latest

* Fix: revert github action to use . action.sh

* Update(dev): make scripts, add commit-bump-undo, read-last-commit

* Chore(commit-bump): new bump target: 1.1.1

* Update(dev): add make to undo a tag (#18)

* Update(dev): push tag using bump.txt value (#19)

* Update(dev): push tag using bump.txt value (#20)
asieduernest12 added a commit that referenced this issue Sep 2, 2023
@asieduernest12
Update(dev): push tag using bump.txt value (#20)
483fc9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request FAQ
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rahilwazir @reaseno @ansh @asieduernest12 @jnk-klver @Sininejuust @tzazixten