Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/lister plugins (Core functionalyti) #100

Merged
merged 22 commits into from
Sep 30, 2024

Conversation

Diaskhan
Copy link
Contributor

@Diaskhan Diaskhan commented Sep 28, 2024

1 part of Feature. (Core functionalyti)
in next PR we will handle other tasksss..

@Diaskhan Diaskhan marked this pull request as draft September 28, 2024 10:06
@Diaskhan Diaskhan marked this pull request as ready for review September 28, 2024 15:00
@Diaskhan Diaskhan changed the title Dev/lister plugins Dev/lister plugins (Core functionalyti) Sep 28, 2024
@anovik anovik self-requested a review September 29, 2024 11:04
Copy link
Owner

@anovik anovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you address a couple of comments.

In general, I think it is better to support plugins only for Windows.


<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" />

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Windows 11, can you add it? I can test if necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 and 11 are the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U can check but need extract plugin in same folder

private void OnWindowOpened(object? sender, EventArgs e)
{

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove extra lines in this function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@anovik anovik merged commit 1410af8 into anovik:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants