Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipefail error caused by piping output to head #270

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix pipefail error caused by piping output to head #270

merged 2 commits into from
May 21, 2023

Conversation

baumac
Copy link
Contributor

@baumac baumac commented May 20, 2023

RE: #269

Summary of changes

Fixes a pipefail error caused by piping output to the head function. Instead of using pipes, output is now saved into vars which are passed between functions.

Breaking Changes

Do any of the included changes break current behaviour or configuration?

NO

How changes have been tested

Tested by creating a repo with 998 tags and then running the workflow against it.

List any unknowns

-N/A

@sbe-arg
Copy link
Collaborator

sbe-arg commented May 20, 2023

Amazing. Ill run a test just to cuadriple confirm.

Thanks a million for this.

@sbe-arg
Copy link
Collaborator

sbe-arg commented May 21, 2023

Looks good, can you address the shellcheck double quoting so we can merge this?

@baumac
Copy link
Contributor Author

baumac commented May 21, 2023

Looks good, can you address the shellcheck double quoting so we can merge this?

Yup, just implemented the suggested fixes from spellcheck so it workflows should pass now 👍

@sbe-arg
Copy link
Collaborator

sbe-arg commented May 21, 2023

Please see #271 XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants