Merge pull request #260 from davidrusu/resolve-build-warnings #537
Clippy
8 errors
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 8 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.77.0 (aedd173a2 2024-03-17)
- cargo 1.77.0 (3fe68eabf 2024-02-29)
- clippy 0.1.77 (aedd173 2024-03-17)
Annotations
Check failure on line 135 in taiga_halo2/src/resource_encryption.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
Check failure on line 135 in taiga_halo2/src/resource_encryption.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/resource_encryption.rs:135:25
|
135 | pub fn padding(msg: &Vec<pallas::Base>) -> Self {
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
help: change this to
|
135 ~ pub fn padding(msg: &[pallas::Base]) -> Self {
136 ~ let mut plaintext = msg.to_owned();
|
Check failure on line 979 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Check failure on line 434 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
Check failure on line 979 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:979:30
|
979 | pub fn word_rotate(bits: &Vec<AssignedCell<F, F>>, by: usize) -> Vec<AssignedCell<F, F>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AssignedCell<F, F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Check failure on line 150 in taiga_halo2/src/circuit/vp_circuit.rs
github-actions / Clippy
use of a fallible conversion when an infallible one could be used
error: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`
Check failure on line 434 in taiga_halo2/src/circuit/blake2s.rs
github-actions / Clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> taiga_halo2/src/circuit/blake2s.rs:434:14
|
434 | ret: &Vec<Blake2sWord<F>>,
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Blake2sWord<F>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-D clippy::ptr-arg` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::ptr_arg)]`
Check failure on line 150 in taiga_halo2/src/circuit/vp_circuit.rs
github-actions / Clippy
use of a fallible conversion when an infallible one could be used
error: use of a fallible conversion when an infallible one could be used
--> taiga_halo2/src/circuit/vp_circuit.rs:150:13
|
150 | val.try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `Vec<Fp>` to `ValidityPredicatePublicInputs` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `-D clippy::unnecessary-fallible-conversions` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_fallible_conversions)]`