Skip to content

Merge pull request #224 from anoma/xuyang/update_nullifier_derivation… #464

Merge pull request #224 from anoma/xuyang/update_nullifier_derivation…

Merge pull request #224 from anoma/xuyang/update_nullifier_derivation… #464

GitHub Actions / Clippy (beta) succeeded Oct 5, 2023 in 0s

Clippy (beta)

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.74.0-beta.1 (b5c050feb 2023-10-03)
  • cargo 1.74.0-beta.1 (59596f0f3 2023-09-29)
  • clippy 0.1.74 (b5c050f 2023-10-03)

Annotations

Check warning on line 177 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:177:44
    |
177 |             borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
    |                                            ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 175 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:175:18
    |
175 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unwrap_or_default)]`

Check warning on line 177 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:177:44
    |
177 |             borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
    |                                            ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 175 in taiga_halo2/src/transaction.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of `unwrap_or` to construct default value

warning: use of `unwrap_or` to construct default value
   --> taiga_halo2/src/transaction.rs:175:18
    |
175 |                 .unwrap_or(vec![])
    |                  ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unwrap_or_default)]`