Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poseidon hash #26

Merged
merged 9 commits into from
Jun 2, 2022
Merged

Poseidon hash #26

merged 9 commits into from
Jun 2, 2022

Conversation

XuyangSong
Copy link
Collaborator

@XuyangSong XuyangSong commented May 31, 2022

  • Add poseidon hash implementation and its circuit
  • Add poseidon hash scripts for hardcode tests
  • Add poseidon hash for BLS12-377 Scalar Field and tests(may need for different WIDTH versions)
  • Add poseidon hash for BLS12-377 Base Field and tests
  • Get rid of Penumbra Poseidon377.
  • Check the parameters generation for different curves, a discussion here
  • When the zk-garage/plonk poseidon hash is merged, fetch the upstream.

@XuyangSong
Copy link
Collaborator Author

XuyangSong commented May 31, 2022

We may need hash from bytes, I'll add it later.
And hashes of bls12_377::BaseField are generated automatically, not tested yet. Especially we need to check the round number generation from the paper.

Let's merge this first. So some works depended on hash can be done in parallel.

@XuyangSong XuyangSong changed the title [WIP]Poseidon hash Poseidon hash Jun 1, 2022
@XuyangSong XuyangSong marked this pull request as ready for review June 1, 2022 13:39
@XuyangSong XuyangSong requested a review from simonmasson June 1, 2022 13:40
@XuyangSong
Copy link
Collaborator Author

To keep consistent with zk-garage plonk, move poseidon impl and tests to ark-plonk.

@simonmasson simonmasson merged commit 60e34c5 into main Jun 2, 2022
@XuyangSong XuyangSong deleted the xuyang/poseidon branch June 2, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants